feat: Inform user if cli is outdated#81
Open
prateek-who wants to merge 1 commit intoMorpheApp:devfrom
Open
Conversation
Contributor
|
3 second timeout is ok. It's only a courtesy check and not critical. The check could run on a background thread so there is no delay before patching starts, but that will cause the console log "cli is outdated" message to appear in a non-deterministic ordering. Sometimes it will be the first line, sometimes mixed in with other patcher log statements. I think how it is now (blocks to check if outdated) is ok because in normal conditions the check will be a fraction of a second. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the user's version with the latest stable version to see if the user's version is outdated. Currently it only runs with the patch subcommand and the network connection has a 3 sec TTL. Any errors are silently thrown and the patching continues. Do we reduce the TTL or is this fine?
It is running on the main thread itself, but it'll block it max for 3 seconds. In case there are any issues with this implementation, please let me know. I'll make the changes