Skip to content

Comments

[GPCAPIM-265] Generate X-Request-Id header#85

Merged
Vox-Ben merged 3 commits intomainfrom
feature/GPCAPIM-265_x_request_id
Feb 19, 2026
Merged

[GPCAPIM-265] Generate X-Request-Id header#85
Vox-Ben merged 3 commits intomainfrom
feature/GPCAPIM-265_x_request_id

Conversation

@Vox-Ben
Copy link
Contributor

@Vox-Ben Vox-Ben commented Feb 10, 2026

Description

This makes the PdsClient generate a fresh UUID with each request to PDS and send it as the X-Request-Id header

Context

PDS requires a fresh X-Request-Id with every request. Previously we were expecting it to be generated by the consumer and passed in, but that is incorrect - it needs to be generated within the PDS module because it is specific to the PDS request and the consumer has no knowledge of it.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Vox-Ben Vox-Ben requested a review from a team as a code owner February 10, 2026 22:13
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Trivy gate: no Critical/High issues.

Trivy IaC (Terraform) Summary

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 0
UNKNOWN 0
Findings (top 50)
Severity ID Title File

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Trivy gate: no Critical/High vulnerabilities.

Trivy Image Scan Summary

Image: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-265-x-request-id

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 1
UNKNOWN 0
Findings (top 50)
Severity ID Package Installed Fixed Source
LOW CVE-2026-1703 pip 25.3 26.0 Python

@Vox-Ben Vox-Ben force-pushed the feature/GPCAPIM-265_x_request_id branch from 869014c to 0178c42 Compare February 19, 2026 14:50
@sonarqubecloud
Copy link

@github-actions
Copy link

Deployment Complete

@Vox-Ben Vox-Ben merged commit 0cab4ee into main Feb 19, 2026
53 checks passed
@Vox-Ben Vox-Ben deleted the feature/GPCAPIM-265_x_request_id branch February 19, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants