Skip to content

Conversation

@mrlockstar
Copy link
Contributor

@mrlockstar mrlockstar commented Dec 3, 2025

Description

We need to configure a container probe (liveness/readiness) for our Azure Container Apps deployment.

By default, the web application should only have a heath probe if the variable probe_path is set.

If probe_path is null then it's disabled.

Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.

image image

Please look for container app manbrs-web-pr-801 for evidence. Note I have observed the container for 10 plus minutes and have been able to log in and off the container without it crashing.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch 4 times, most recently from b934660 to 2fdcd65 Compare December 3, 2025 23:32
@saliceti
Copy link
Contributor

saliceti commented Dec 4, 2025

Please run terraform-docs when you're done

@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch 2 times, most recently from 9713e6d to ccd8397 Compare December 8, 2025 16:32
@mrlockstar mrlockstar requested a review from saliceti December 9, 2025 11:20
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch 4 times, most recently from ffc3347 to 9b01b7d Compare December 9, 2025 12:18
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from 9b01b7d to 7e92d3b Compare December 9, 2025 12:20
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from 7e92d3b to 81a96ce Compare December 9, 2025 12:24
We need to configure a container probe (liveness/readiness & startup) for our Azure Container Apps deployment.
By default, the web application should only have a heath probe if the variable probe_path is set.
If probe_path is null then it's disabled.
Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.
Also update the terradocs on the container app module and update the README.md for instructions on how to deploy probes from the root module.
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from 81a96ce to d26e08b Compare December 9, 2025 12:28
@mrlockstar mrlockstar added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit b72093d Dec 9, 2025
13 checks passed
@mrlockstar mrlockstar deleted the DTOSS-11646-Setup-Container-Apps-container-probes branch December 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants