Update: [AEA-6053] - document preprocessing#221
Merged
anthony-nhs merged 45 commits intomainfrom Jan 26, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6053 |
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
…mbda Two fixes for preprocessing Lambda: 1. Grant KMS permissions: Added kmsKey.grantEncryptDecrypt() to allow Lambda to decrypt files from raw/ and encrypt files to processed/ 2. Auto-create folders: Use BucketDeployment to create raw/ and processed/ folders on stack deployment. Much simpler than custom resource approach. Files: - packages/cdk/assets/s3-folders/raw/.gitkeep - packages/cdk/assets/s3-folders/processed/.gitkeep - packages/cdk/stacks/EpsAssistMeStack.ts
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
Suppress cdk-nag warnings for: - BucketDeployment IAM managed policy usage - BucketDeployment wildcard S3/KMS permissions - BucketDeployment Lambda runtime - Preprocessing Lambda KMS wildcard permissions (GenerateDataKey*, ReEncrypt*)
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
Critical bug: S3Bucket constructor was using this.kmsKey before it was assigned. Changed line 34 from 'encryptionKey: this.kmsKey' to 'encryptionKey: kmsKey' to use the local variable that was already created. This prevented the bucket from being properly encrypted with our KMS key, which is why the preprocessing Lambda couldn't decrypt objects.
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
bencegadanyi1-nhs
had a problem deploying
to
dev-pr
GitHub Actions
Failure
kieran-wilkinson-4
previously approved these changes
Jan 21, 2026
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
previously approved these changes
Jan 21, 2026
|
bencegadanyi1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
connoravo-nhs
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
raw/-> preprocessing ->processed/-> sync/tmpsecurity issue with secure temp directory handling