Skip to content

VED-798 Validation Engine - integration with backend #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JamesW1-NHS wants to merge 20 commits into
base: staging/VED-508-validation-refactor-and-dq-feature
Choose a base branch
from
Open

VED-798 Validation Engine - integration with backend #996

JamesW1-NHS wants to merge 20 commits into from

Conversation

@JamesW1-NHS
Copy link
Contributor

@JamesW1-NHS JamesW1-NHS commented Nov 20, 2025 •
edited
Loading

Summary

  • ❗ Breaking Change

** Parked pending design/implementation of the validator with JSON Schemas

NB: this is a WIP. The changes only action the backend at the moment - not the batch processor.
Some tests have been patched pending update of the validation engine.
recordforwarder tests work, though they have been patched temporarily.

e2e tests don't work at the moment. Reason: the schema isn't in redis, therefore the validator is trying to parse an empty schema and returning an HTTP 400. We would have to add the schema into redis via terraform.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

dependabot bot and others added 13 commits November 12, 2025 12:15
@dependabot @dlzhry2nhs
Bump @redocly/cli from 2.11.0 to 2.11.1 in the npm-minor-patch group (#…
9fc0dc1 
…980)

* Bump @redocly/cli from 2.11.0 to 2.11.1 in the npm-minor-patch group

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.11.0...@redocly/cli@2.11.1)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.11.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger Build

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>
@JamesW1-NHS
VED-807 Refactor backend (#967)
954c7e3 
* init: move recordforwarder, copy src/models

* temp: sonar.cpd.exclusions

* nosonar

* temp: sonar.exclusions

* test: remove Dockerfile path

* test: remove Dockerfile path II

* test: remove Dockerfile path III

* fix source_path

* lint

* init: move batch source and tests, duplicate testing_utils

* backend -> lambdas

* cleanup docker tags

* sonar

* lambdas/backend

* sonar

* source_path

* clients/redis_client

* errors

* ruff

* shared/src/common/models

* TEMP: sonar exclusions

* TEMP: sonar exclusions II

* ruff

* cache

* interim - for merge

* interim - for merge II

* path fix

* backend tests

* ruff

* poetry.lock

* smells

* smell: pydantic.ValidationError

* smell: expression_attribute_values

* ApiValidationError

* errors / api_errors

* errors / api_errors II

* backend -> shared

* :${{ env.SHARED_PATH }}/tests

* recordforwarder -> shared

* sonar

* S5332

* smells

* smells II

* smells III

* constants

* ruff

* errors

* rest of errors

* ruff

* singleton s3 client

* shared s3 client II

* mesh_processor env

* assert bug fix attempt

* move_file

* move_file II

* reworked test_clients

* bucket cleanup

* get_nhs_number

* make_*_pk

* make_*_pk II

* cleanup

* remove cpd.exclusions

* utils -> aws_s3_utils

* backend/src/constants

* backend/src/constants II

* utils -> aws_s3_utils II

* remove PII

* revert PK stuff from generic_utils
@JamesW1-NHS
remove error logging (#984)
54dcd37
@dependabot
Bump the pip-minor-patch group across 12 directories with 4 updates (#…
30fb156 
…985)
@JamesW1-NHS
Merge branch 'master' into VED-798-Validation-Engine
f6bf9fb
@JamesW1-NHS
interim: added validator engine to ImmunizationValidator, added Valid…
390acca 
…atorError
@JamesW1-NHS
interim: so we don't freeze trying to contact redis
fdcb6fe
@JamesW1-NHS
fix schema, args, some tests
ba56995
@JamesW1-NHS
TEMP: debug tracing
964933e
@JamesW1-NHS
interim: create_immunization
4bcf6e0
@JamesW1-NHS
reworked fhir_immunization, test_fhir_service
63cc7e7
@JamesW1-NHS
ruff
912cd29
@JamesW1-NHS
ImmunizationValidator calls
a37486b
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-798

@JamesW1-NHS JamesW1-NHS changed the title Ved 798 Validation Engine - integration with backend VED-798 Validation Engine - integration with backend Nov 21, 2025
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 12:11 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 12:14 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 12:29 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 12:32 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 13:02 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 13:05 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 13:47 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox November 21, 2025 13:47 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS mentioned this pull request Nov 21, 2025
Closed
@dlzhry2nhs
Copy link
Contributor

dlzhry2nhs commented Dec 9, 2025

Work has been paused on this approach. Worth considering closing the PR. Especially if we get a clear outcome from VED-947 which results in us redesigning the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesW1-NHS @dlzhry2nhs