Skip to content

PRMP-1087 Refactor document review status lock handling #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NogaNHS merged 8 commits into from
Jan 8, 2026
Merged

PRMP-1087 Refactor document review status lock handling #963

NogaNHS merged 8 commits into from
Jan 8, 2026

Conversation

@NogaNHS
Copy link
Contributor

@NogaNHS NogaNHS commented Dec 18, 2025 •
edited by steph-torres-nhs
Loading

Overview

Jira ticket: PRMP-1087

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@NogaNHS NogaNHS changed the title Refactor document review status handling PRMP-1087 Refactor document review status lock handling Dec 18, 2025
@NogaNHS
Refactor document review status handling: replace APPROVED_PENDING_DO…
b5377a8 
…CUMENTS with REVIEW_IN_PROGRESS and update related methods
@NogaNHS
Update document review status handling: replace REVIEW_IN_PROGRESS wi…
e866afd 
…th PENDING_REVIEW in tests and validation
@NogaNHS NogaNHS marked this pull request as ready for review January 5, 2026 13:40
@NogaNHS NogaNHS requested review from a team as code owners January 5, 2026 13:40
@NogaNHS NogaNHS enabled auto-merge (squash) January 8, 2026 10:30
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NogaNHS NogaNHS merged commit 7233ab2 into main Jan 8, 2026
25 of 26 checks passed
@NogaNHS NogaNHS deleted the PRMP-1087 branch January 8, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lillie-dae lillie-dae lillie-dae approved these changes

@steph-torres-nhs steph-torres-nhs steph-torres-nhs approved these changes

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NogaNHS @lillie-dae @steph-torres-nhs