[PRMP-1158] Review POST/ virus scan integration bug #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
adamwhitingnhs
previously approved these changes
Jan 5, 2026
NogaNHS
previously approved these changes
Jan 5, 2026
steph-torres-nhs
dismissed stale reviews from NogaNHS and adamwhitingnhs
via
e4c0658
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
previously approved these changes
Jan 8, 2026
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
previously approved these changes
Jan 8, 2026
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
adamwhitinganswer
approved these changes
Jan 8, 2026
adamwhitingnhs
previously approved these changes
Jan 8, 2026
steph-torres-nhs
dismissed stale reviews from adamwhitingnhs and NogaNHS
via
57e2bf3
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
Code security issues foundView full details here. |
|
adamwhitingnhs
approved these changes
Jan 8, 2026
NogaNHS
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-1158
Description
Removal of checking file is in the expected location before scanning for viruses.
Context
On uploading new files for review, when a new entry is created in the document pending review table a file location is not set on the object as it is unknown whether the upload via CloudFront will have happened successfully. The virus scan check process checks for an expected file location and is unable to find anything and so the lambda fails, meaning the object is neither scanned nor moved from staging to review bucket.
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)[] 4. I have updated relevant documentation.[ ] 6a.Deploy - Sandbox- workflow run - TBCSANDBOX Full- Deploy feature branch to sandbox- workflow run