CCM-13615: Status Update Transformer Source #309
+147
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masl2
force-pushed
the
feature/CCM-13615_letter-status-source
branch
from
1adb1f1 to
588bf5a
Compare
masl2
force-pushed
the
feature/CCM-13615_letter-status-source
branch
from
588bf5a to
6d35b7f
Compare
m-houston
reviewed
Dec 17, 2025
lambdas/letter-updates-transformer/src/letter-updates-transformer.ts
Outdated
Show resolved
Hide resolved
m-houston
previously approved these changes
Dec 17, 2025
…mer.ts Co-authored-by: Mike Houston <60653100+m-houston@users.noreply.github.com>
stevebux
reviewed
Dec 17, 2025
Contributor
stevebux
left a comment
stevebux
left a comment
There was a problem hiding this comment.
Looks good, a couple of very minor comments
lambdas/letter-updates-transformer/src/__tests__/letter-updates-transformer.test.ts
Outdated
Show resolved
Hide resolved
lambdas/letter-updates-transformer/src/letter-updates-transformer.ts
Outdated
Show resolved
Hide resolved
m-houston
previously approved these changes
Dec 23, 2025
Contributor
Author
|
Should probably wait until after #280 to ensure we don't lose the value passthrough to the outbound events |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add account (short name) and environment to the status update source field to enable better routing and filtering for the events
Additionally allow INSERT events as these will be linked to new letter creation and will inform other services a letter has been registered/allocated in the supplier api (via PENDING status)
Finally move payload extraction to discrete non pipe step to help ensure payloads are logged - filtered payloads were not being logged
Enables identification of account and environment source for events
Ensures PENDING statuses will be generated
Improves logging for debugging
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.