Skip to content

[PRM-667] Reverted removal of end_of_transfer #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oliverbeumkes-nhs wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[PRM-667] Reverted removal of end_of_transfer #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions stacks/deductions-cross-account/terraform/ecr.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
pull_through_cache_prefix = "docker-hub"
}

resource "aws_ecr_repository" "ehr_out_service" {

Check failure on line 5 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_136: "Ensure that ECR repositories are encrypted using KMS"

Check failure on line 5 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_163: "Ensure ECR image scanning on push is enabled"
name = "deductions/ehr-out-service"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
Expand All @@ -10,15 +10,7 @@
}
}

resource "aws_ecr_repository" "gp2gp-adaptor" {
name = "deductions/gp2gp-adaptor"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
CreatedBy = var.repo_name
}
}

resource "aws_ecr_repository" "gp2gp-messenger" {

Check failure on line 13 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_136: "Ensure that ECR repositories are encrypted using KMS"

Check failure on line 13 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_163: "Ensure ECR image scanning on push is enabled"
name = "deductions/gp2gp-messenger"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
Expand All @@ -26,7 +18,7 @@
}
}

resource "aws_ecr_repository" "ehr-transfer-service" {

Check failure on line 21 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_136: "Ensure that ECR repositories are encrypted using KMS"

Check failure on line 21 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_163: "Ensure ECR image scanning on push is enabled"
name = "deductions/ehr-transfer-service"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
Expand All @@ -34,7 +26,7 @@
}
}

resource "aws_ecr_repository" "ehr-repo" {

Check failure on line 29 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_136: "Ensure that ECR repositories are encrypted using KMS"

Check failure on line 29 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_163: "Ensure ECR image scanning on push is enabled"
name = "deductions/ehr-repo"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
Expand All @@ -42,7 +34,7 @@
}
}

resource "aws_ecr_repository" "mhs-inbound" {

Check failure on line 37 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_136: "Ensure that ECR repositories are encrypted using KMS"

Check failure on line 37 in stacks/deductions-cross-account/terraform/ecr.tf

View workflow job for this annotation

GitHub Actions / Checkov Scan 

CKV_AWS_163: "Ensure ECR image scanning on push is enabled"
name = "mhs-inbound"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
Expand Down Expand Up @@ -122,14 +114,6 @@
}
}

resource "aws_ecr_repository" "gp_registrations_mi_forwarder" {
name = "repo/gp-registrations-mi-forwarder"
image_tag_mutability = var.immutable_ecr_repositories ? "IMMUTABLE" : "MUTABLE"
tags = {
CreatedBy = var.repo_name
}
}

data "aws_iam_policy_document" "ecr_promotion_account_permissions" {
count = var.environment == "prod" ? 0 : 1

Expand Down
2 changes: 1 addition & 1 deletion tasks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function tf_plan {
cd "${DEDUCTIONS_INFRA_DIR}/terraform/"

if [[ "${certs}" == "true" ]]; then
TARGET="-target=module.deductions-private.aws_acm_certificate.mq-admin-cert -target=module.deductions-private.aws_acm_certificate.gp2gp-adaptor-cert"
TARGET="-target=module.deductions-private.aws_acm_certificate.mq-admin-cert"
fi

configure_tf_plan_filename $certs
Expand Down