feat(ssm-parameter): add ssm parameter module#82
Conversation
| @@ -0,0 +1,21 @@ | |||
| module "ssm_parameter" { | |||
| source = "terraform-aws-modules/ssm-parameter/aws" | |||
| version = "~> 2.1.0" | |||
There was a problem hiding this comment.
Please pin to an explicit module version
| locals { | ||
| # if the name is a path (contains a slash), | ||
| # then it must be fully qualified (start with a slash) | ||
| name = ( |
There was a problem hiding this comment.
module.this.id should be used here and it won't contain "/" by our standards, but will be a '-' separated string.
Please can you review this, switch to use .id, add a path parameter - similar to 'iam' module.
There was a problem hiding this comment.
Add validation or assert to ensure kms_id is specified if using a secure parameter.
There was a problem hiding this comment.
Please align document sections/headings and contents with repo standards
|
You can leverage the /new-terraform-module Copilot skill to assist with the structure alignment and if you also give it the upstream module it should assist in scaffolding/building the module. |
nhs-oliverslater
force-pushed
the
feature/BCSS-23623-add-ssm-param-module
branch
from
a82e1e2 to
6a908de
Compare
2 participants
BCSS-23623
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.