Feature/use mise tool instead of script calls#85
Draft
nhs-oliverslater wants to merge 3 commits into
Draft
Conversation
Implement a hard separation between active referenced tasks and unreferenced starter scripts in mise.toml. - Split mise tasks into maintained (referenced by automation/docs) and unreferenced (starter/manual) - Comment out 9 unreferenced tasks: docker-*, tests-* (unit, style, release-config, release-updater) - Keep terraform-derive-module-constraints and terraform-wrapper active as maintained manual utilities - Add test-mise-task-surface.sh to enforce that all referenced tasks are active and no commented tasks are referenced - Update pre-commit hooks to use mise task invocations instead of raw script paths - Update GitHub Actions composite actions to use mise tasks for consistency - Update all documentation (README, instruction files, skills, prompts) to reference mise tasks - Add comprehensive README note on terraform-derive-module-constraints with prerequisites and interpretation guidance - Fix test expectations: terraform module upgrade (darwin_arm64 platform) and workflow security (mise task references) - All 6 test suites now pass (161 total test cases) This ensures the mise task surface remains maintainable and consistent between configuration, automation, and documentation.
- Replaced test-conventional-commit.sh with test-conventional-commit.bats. - Replaced test-generate-dependabot-config.sh with test-generate-dependabot-config.bats. - Replaced test-mise-task-surface.sh with test-mise-task-surface.bats. - Replaced test-module-upgrade.sh with test-module-upgrade.bats. - Replaced test-tool-version-upgrade.sh with test-tool-version-upgrade.bats. - Replaced test-workflow-security.sh with test-workflow-security.bats. - Added shared assertion helpers in tests/test_helper/assertions.bash. - Updated tests to use new assertion methods and improved structure.
Replace static prerequisite metadata with @name/@url/@purpose/@Prefix annotations in mise.toml and parse them in update-tool-versions.sh. Also remove mapfile usage for Bash 3.2 compatibility in scripts/tests and regenerate lock/version artefacts and related tests.
Contributor
Author
|
Will need updating AFTER #89 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.