added event bridge lambda and new vault to facilitate new cross account copy job method#42
Closed
aidanharrisnhs wants to merge 7 commits intomainfrom
Closed
Conversation
…nt copy job method
regularfry
reviewed
May 23, 2025
…diary-vault-implementation
…diary-vault-implementation
pennytextures
approved these changes
Jun 25, 2025
Contributor
pennytextures
left a comment
pennytextures
left a comment
There was a problem hiding this comment.
It'd be nice if the documentation were updated too, but e-RS has already put this branch live and it works fine.
Happy to add documentation myself after this is in
regularfry
added
enhancement
Contributor
|
This branch has an unsigned commit and can't be merged, so it's been redone as #50. Closing this in favour of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
we added a new intermediary vault and pointed the backup plans to it, this allows us to change the kms keys of the recovery points so they inherit the kms key of the intermediary vault so they have a customer managed key to enable cross account transfers. We also added an event bridge to detect new recovery points being made in the intermediary vault, which kicks off a lambda which starts another copy job to the destination vault.
Type of changes
This change allows teams to AWS managed keys on their databases and still be able to have them backed up to another account.
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.