Skip to content

SPINECORE-6443: add copy_target_arn_list which is a list of arns#52

Open
tom-gowland-nhs wants to merge 1 commit intomainfrom
feature/SPINECORE-6433-extend-blueprint-to-allow-a-copy-targets-list-variable-which-is-an-arn-list
Open

SPINECORE-6443: add copy_target_arn_list which is a list of arns#52
tom-gowland-nhs wants to merge 1 commit intomainfrom
feature/SPINECORE-6433-extend-blueprint-to-allow-a-copy-targets-list-variable-which-is-an-arn-list

Conversation

@tom-gowland-nhs
Copy link
Contributor

@tom-gowland-nhs tom-gowland-nhs commented Jun 27, 2025

Description

  • Change test condition to check against ArnNotEquals which is more precise than StringNotEquals (as discussed with @regularfry)
  • Adds a new copy_target_arn_list variable which allows the list of restoration accounts to be passed in dynamically
  • Adds a copy_targets local to retain the pre-existing default restoration account from the blueprint

Context

Required as we needed a way to pass through a different restoration account ARN as well as being able to specify multiple ARNS which are valid for restoration.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@tom-gowland-nhs tom-gowland-nhs requested a review from a team as a code owner June 27, 2025 14:40
@regularfry regularfry added enhancement New feature or request breaking A change that alters the API or behaviour in a breaking way labels Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A change that alters the API or behaviour in a breaking way enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments