odin: rename backup notifications key arn and make optional#71
Open
matt-mercer wants to merge 1 commit intomainfrom
Open
odin: rename backup notifications key arn and make optional#71matt-mercer wants to merge 1 commit intomainfrom
matt-mercer wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bootstrap_kms_key_arntobackup_notifications_kms_key_arnin source module and allowed this to be optional, so the module will create a kms key if one not suppliedbreaking in the variable rename, but non-breaking from a resource perspective
Context
the previous bootstrap_kms_key_arn variable is confusing in as to the purpose, and since this key is required by the module, it seems sensible to get the module to auto create this key, but support passing in the notifications key arn for backward compatibility
since this is a central module, we should be running trivy and tf-lint on these to ensure quality and security locally
Type of changes
Checklist