Open
Conversation
Signed-off-by: adil-a <adil.asif2000@hotmail.com>
…ther (original behavior) Signed-off-by: adil-a <adil.asif2000@hotmail.com>
Signed-off-by: adil-a <adil.asif2000@hotmail.com>
Contributor
Author
|
/ok to test a1b93b7 |
akoumpa
changed the title
akoumpa
requested review from
HuiyingLi,
adil-a and
hemildesai
as code owners
akoumpa
requested review from
oliverholworthy,
rnyak,
shan-nvidia and
ybabakhin
as code owners
adil-a
reviewed
Jan 20, 2026
| _write_metadata(output_files_data) | ||
| # Step 3: Write actual tensor data from input files to output files | ||
| _write_data(input_files_data, output_files_data, num_threads) | ||
| if use_staging: |
Collaborator
There was a problem hiding this comment.
staging work is sitll here. is this needed? if not let's remove the staging changes
Member
There was a problem hiding this comment.
Will let @akoumpa confirm, but I don't think we want the staging changes here. The idea is to only have a single file descriptor that we pass around instead of mode="a" appending to files.
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test efcdcb1 |
jrbourbeau
reviewed
Jan 20, 2026
| save_sharded: bool = False, | ||
| consolidated_output_path: Optional[str] = None, | ||
| num_threads_consolidation: Optional[int] = None, | ||
| staging_dir: Optional[str] = None, |
Member
There was a problem hiding this comment.
Thanks for the update @akoumpa. It looks like there are other references to the staging approach still (here and in other files this PR touches)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information