chore: update review code skill output and tone#477
Merged
Conversation
- Remove Overview metadata table from review output - Add cordial tone guidelines and thank-you opening - Tie verdict strictly to highest-severity finding - Soften severity section headers - Add Step 7 to post review as GitHub PR comment - Omit empty severity sections from output Closes #476 Made-with: Cursor
Contributor
Greptile SummaryThis PR refines the Key changes:
|
| Filename | Overview |
|---|---|
| .agents/skills/review-code/SKILL.md | Review skill updated: removes Overview metadata table, adds Tone section before Step 6, tightens Verdict criteria to severity hierarchy, softens severity headers, adds AI signature, and adds confirmation-gated Step 7 for posting. One minor logical ambiguity in Verdict selection when both Warning findings and "Needs discussion" issues coexist. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Review Complete] --> B{Any findings?}
B -- No --> V1[🟢 Ship it]
B -- Yes --> C{Design/arch\nquestions?}
C -- Yes --> V4[💬 Needs discussion]
C -- No --> D{Highest severity?}
D -- Critical or Warning --> V3[🔴 Needs changes\nList blocking items]
D -- Suggestions only --> V2[🟡 Ship it with nits]
V3 --> E[Step 7: Display review\n+ ask user to confirm\nbefore posting]
V2 --> E
V1 --> E
V4 --> E
E --> F{User confirms?}
F -- Yes --> G[gh pr comment <number>\n--body-file /tmp/review-<n>.md]
F -- No --> H[Done — review saved\nto /tmp/review-<n>.md]
Prompt To Fix All With AI
This is a comment left during a code review.
Path: .agents/skills/review-code/SKILL.md
Line: 244-249
Comment:
**Verdict selection ambiguous when both Warnings and "Needs discussion" apply**
The instruction "Choose the verdict that matches the **highest severity** finding" establishes a clear severity ladder (Critical → Warning → Suggestion), but `Needs discussion` isn't a severity level — it's triggered by a qualitatively different condition (unresolved architectural/design questions). When a review contains both a Warning-level code finding *and* a blocking design question, the agent has no rule to decide which verdict wins.
Consider making the precedence explicit, for example:
```suggestion
Choose the verdict that matches the **highest severity** finding in the review. If there are both code findings and unresolved design questions, prefer **Needs discussion** since those questions must be settled before code-level feedback can be finalized:
- **Ship it** — No findings. Ready to merge as-is.
- **Ship it (with nits)** — Only Suggestions (see above — style improvements, simplifications, or optional enhancements). Nothing blocking.
- **Needs changes** — Any Critical or Warning findings. List the items that must be addressed before merge.
- **Needs discussion** — Architectural or design questions that need team input before a decision can be made. Takes precedence over Needs changes when the design itself is unsettled.
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (5): Last reviewed commit: "Merge branch 'main' into nmulepati/chore..." | Re-trigger Greptile
johnnygreco
reviewed
Mar 31, 2026
johnnygreco
reviewed
Mar 31, 2026
johnnygreco
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh pr commentExample review generated with the updated skill
Closes #476