clean commit with EMTTS text embedding disabling and pronunciation co…#15717
Open
paarthneekhara wants to merge 1 commit into
Open
clean commit with EMTTS text embedding disabling and pronunciation co…#15717paarthneekhara wants to merge 1 commit into
paarthneekhara wants to merge 1 commit into
Conversation
…ntrol changes Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
blisc
reviewed
May 22, 2026
Collaborator
blisc
left a comment
blisc
left a comment
There was a problem hiding this comment.
Let's add more documentation to what these changes are.
| from nemo.utils import logging | ||
|
|
||
|
|
||
| def setup_pronunciation_control_g2p(pronunciation_control_g2p_config): |
Collaborator
There was a problem hiding this comment.
Can you add docstrings to your new functions?
| return aggregated_tokenizer | ||
|
|
||
|
|
||
| def setup_pronunciation_control_g2p(pronunciation_control_g2p_config): |
Collaborator
There was a problem hiding this comment.
If the new functions are the same between the two datasets, can we merge the two functions and import rather than defining it twice?
| self.phoneme_loss_weight = cfg.get('phoneme_loss_weight', 1.0) | ||
| self.parallel_codebook_loss_scale = cfg.get('parallel_codebook_loss_scale', 1.0) | ||
| self.local_transformer_loss_scale = cfg.get('local_transformer_loss_scale', 1.0) | ||
| self.phoneme_as_text_prob = cfg.get('phoneme_as_text_prob', 0.0) |
Collaborator
There was a problem hiding this comment.
Where is this new parameter being defined? Or is it always going to be 0?
Comment on lines
+269
to
+275
| self.disable_subword_embedding = cfg.get('disable_subword_embedding', False) | ||
| self.disable_lm_text_head = cfg.get('disable_lm_text_head', False) | ||
| if self.disable_subword_embedding and not self.use_bpe_char_tokenizer: | ||
| logging.warning( | ||
| "`disable_subword_embedding=True` requires `use_bpe_char_tokenizer=True`; overriding automatically." | ||
| ) | ||
| self.use_bpe_char_tokenizer = True |
Collaborator
There was a problem hiding this comment.
Can you document what your new arguments mean?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.