fix sglang_patch. fix apptainers action execution#29
Open
skzhang1 wants to merge 2 commits into
Open
Conversation
Contributor
skzhang1
commented
May 18, 2026
skzhang1
commented
- fix sglang patch
- fix apptainer in cluster
There was a problem hiding this comment.
Pull request overview
This PR adjusts Apptainer runtime execution to support direct apptainer exec mode for cluster environments and updates the SGLang patch script to persist canonical prompt token IDs after tokenization.
Changes:
- Adds optional direct-exec mode for Apptainer, including shared overlay setup and command prefix reuse.
- Updates the SGLang patch to store
input_token_idson request state and emit them throughmeta_info.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/polar/runtime/apptainer.py |
Adds direct-exec support and centralizes Apptainer exec argument construction. |
scripts/patch/patch_sglang.sh |
Updates tokenizer manager patching to persist and expose prompt token IDs from request state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+31
| self._direct_exec = bool(os.environ.get("POLAR_APPTAINER_DIRECT_EXEC")) or bool( | ||
| spec.kwargs.get("direct_exec", False) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.