refactor(sft): migrate SFTConfig, SFTSaveState to BaseModel#2525
Open
NolenLiang wants to merge 3 commits into
Open
refactor(sft): migrate SFTConfig, SFTSaveState to BaseModel#2525NolenLiang wants to merge 3 commits into
NolenLiang wants to merge 3 commits into
Conversation
NolenLiang
added
the
CI:Lfast
Contributor
Author
|
/ok to test 3238765 |
Contributor
Author
|
/ok to test 9fb9969 |
Convert 2 TypedDict classes to pydantic BaseModel with extra="allow": - SFTConfig: 9 required fields - SFTSaveState: 5 fields with defaults + val_loss Optional[float] Update all dict-style access to attribute access in sft.py. Wrap model_construct sft dict in test_sft.py with SFTConfig.model_construct(). Signed-off-by: nliang <nliang@nvidia.com>
Signed-off-by: nliang <nliang@nvidia.com>
NolenLiang
force-pushed
the
nliang/typeddict-to-basemodel-sft
branch
from
9fb9969 to
74d09f7
Compare
Contributor
Author
|
/ok to test 74d09f7 |
Add defaults to SFTConfig fields matching the reference config (sft.yaml). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: nliang <nliang@nvidia.com>
Contributor
Author
|
/ok to test 6231300 |
NolenLiang
added
CI:L1
Contributor
Author
|
/ok to test 6231300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert 2 TypedDict classes to pydantic BaseModel with extra="allow":
Update all dict-style access to attribute access in sft.py. Wrap model_construct sft dict in test_sft.py with SFTConfig.model_construct().
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Results before / after the changes