feat: use generic OpenClaw plugin config#102
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughMigrates OpenClaw observability from legacy top-level ChangesOpenClaw → NeMo Flow plugin-host migration
Sequence DiagramsequenceDiagram
participant Config as Config (plugins.entries["nemo-flow"].config)
participant Runtime as Nemo Flow Runtime
participant PluginHost as Plugin Host / Components
participant HookBackend as HookReplayBackend
participant Exporter as Observability exporters (FS/OTLP/OpenInference)
Config->>Runtime: start with plugin-host observability config
Runtime->>PluginHost: validatePluginHostConfig(plugins.config)
PluginHost-->>Runtime: ok / diagnostics / error
Runtime->>HookBackend: construct HookReplayBackend(agentVersion, config)
HookBackend->>HookBackend: emit replay events (no ATIF wrapper)
HookBackend->>PluginHost: deliver replay events to components
PluginHost->>Exporter: observability component writes ATIF/OTLP/OpenInference (if enabled)
PluginHost-->>Runtime: initialization status (initializedPluginHost, outputs healthy)
Runtime->>Runtime: compute health snapshot from plugins.components + plugin-host status
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:XL
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integrations/openclaw/src/__tests__/config.test.ts`:
- Around line 308-363: The test unconditionally uses the native binding via
defaultNemoFlowModuleLoader (called in registerPlugin) and will fail where
nemo-flow-node is unavailable; add a skip guard around this spec (or move it to
an opt-in test) by checking the same feature flag used in live-smoke.test.ts
(e.g., liveSmokeEnabled or an env var) before running the body that calls
registerPlugin/createApi, and short-circuit the test with this.skip() or return
when the native binding is not present so the test only runs in environments
that opt in to native integration tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: d7bfce65-5d0b-41ab-b3d1-fc047286a697
📒 Files selected for processing (25)
README.mddocs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/export-observability-data/observability-plugin.mddocs/integrate-frameworks/openclaw-plugin.mddocs/use-adaptive-optimization/configure.mdintegrations/openclaw/README.mdintegrations/openclaw/openclaw.plugin.jsonintegrations/openclaw/package.jsonintegrations/openclaw/src/__tests__/atif-capture.test.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/__tests__/failure-model.test.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/__tests__/llm-replay.test.tsintegrations/openclaw/src/__tests__/telemetry.test.tsintegrations/openclaw/src/__tests__/tool-replay.test.tsintegrations/openclaw/src/atif-capture.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/hook-replay/session.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/telemetry.ts
💤 Files with no reviewable changes (9)
- integrations/openclaw/src/tests/atif-capture.test.ts
- integrations/openclaw/src/tests/telemetry.test.ts
- integrations/openclaw/src/telemetry.ts
- integrations/openclaw/package.json
- integrations/openclaw/src/atif-capture.ts
- integrations/openclaw/src/tests/tool-replay.test.ts
- integrations/openclaw/src/tests/llm-replay.test.ts
- integrations/openclaw/src/tests/failure-model.test.ts
- integrations/openclaw/src/hook-replay/session.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (34)
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst,txt}: SpellNVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as 'here' or 'read more.'
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical documentation.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented documentation unless the source, platform, or legal guidance explicitly requires them.
Do not add trademark symbols to NeMo Flow learning documentation by default.
Do not rewrite API names, package names, command flags, or code literals for style reasons.
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,markdown,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
**/*.{md,markdown,rst}: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Use monospace formatting for code elements, commands, parameters, package names, and expressions
Use monospace formatting for directories, file names, and paths
Use angle brackets inside monospace for variables inside paths, such as/home/<username>/.login
Use quotation marks for error messages and strings in documentation
Use bold formatting for UI buttons, menus, fields, and labels in documentation
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use in documentation
Use italics for publication titles in documentation
Use plain text formatting for keyboard shortcuts in documentation
Prefer[NVIDIA/NeMo](link)format for GitHub repository references over generic phrases like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text in documentation
Avoid generic link anchors such as 'here,' 'this page,' and 'read more' in documentation
Include the acronym in link text if a linked term includes an acronym
Do not link long sentences or multiple sentences in documentation
Avoid links that pull readers away from a procedure unles...
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{html,md}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license headers in HTML and Markdown files using HTML comment syntax
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
docs/**/*.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run
./scripts/build-docs.shfor documentation site changes
docs/**/*.md: Relevant getting-started or reference docs must be updated when examples change
Release-policy docs must point to GitHub Releases as the only release-history source of truth
docs/**/*.md: Use title case for headings in technical documentation
Introduce code blocks, tables, and lists with complete lead-in sentences in documentation
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run Markdown link checking via
lycheeforREADME.md,CONTRIBUTING.md, anddocs/through pre-commit hooks
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,markdown,py,sh,bash,js,ts,java,cpp,go,rust}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current in documentation
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/README.mdintegrations/openclaw/src/health.tsdocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
{RELEASING.md,CHANGELOG.md,docs/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep release-process and release-notes guidance in repo-maintainer docs such as RELEASING.md, not as user-facing docs pages or CHANGELOG.md
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,markdown,py,sh,bash}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep stable user-facing wrappers at scripts/ root in docs and examples; only point at namespaced helper paths when documenting internal maintenance work
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,markdown,py,sh,bash,js,ts,example}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Example commands must match current package names and paths
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/README.mdintegrations/openclaw/src/health.tsdocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
{scripts/*.sh,docs/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Use root
./scripts/*.shcommands in docs and contributor guidance as documented, with implementations underscripts/third-party/
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mddocs/integrate-frameworks/openclaw-plugin.md
{docs/**,examples/**,crates/adaptive/**,python/nemo_flow/**,go/nemo_flow/**,**/{example,component}.{ts,tsx,js,rs,py,go}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Any new adaptive component kind must have documentation, examples, and binding coverage across all supported languages
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mddocs/integrate-frameworks/openclaw-plugin.md
{README*,CHANGELOG*,docs/**/*.{md,rst,txt},examples/**/*,*.md}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update documentation, examples, and getting-started guides with new package/module/crate names after rename operations
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,txt,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
**/*.{md,txt,rst}: Ensure commands, package names, file paths, and APIs in documentation are correct and not stale; flag incorrect or outdated information as blocking issues
Ensure examples and procedures in documentation will execute successfully with current APIs and commands
Use consistent user-facing terminology throughout documentation that matches current repo terminology
Capitalize NVIDIA correctly in all documentation and public-facing text
Format code, commands, paths, and filenames as inline code (monospace) in documentation
Use descriptive anchor text for links instead of bare URLs or weak labels like 'here' in documentation
Prefer active voice, present tense, short sentences, and plain English in documentation
Structure documentation procedures as imperative steps that are easy to scan and not too long for a single sequence
Prefer 'after' instead of 'once' for temporal references in documentation
Use 'can' instead of 'may' when describing possibility (rather than permission) in documentation
Avoid ambiguous numeric dates and ordinal dates in documentation body text
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/README.mddocs/integrate-frameworks/openclaw-plugin.md
{README.md,docs/**/*.md,examples/**/*.{js,ts,py,go,rs}}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep documentation and examples synchronized with current install, import, and build commands
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{py,js,ts,tsx,go,rs,md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Format changed files with the language-native formatter before the final lint/test pass
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mdintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/README.mdintegrations/openclaw/src/health.tsdocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
{README.md,CONTRIBUTING.md,docs/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
For docs-only changes, run targeted checks only if commands, package names, or examples changed. Use
just docsfor docs-site builds andjust docs-linkcheckwhen links changed
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mddocs/integrate-frameworks/openclaw-plugin.md
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency across language bindings.
Flag stale examples, missing SPDX headers where required, and instructions that no longer match CI or pre-commit behavior.
Files:
docs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/use-adaptive-optimization/configure.mddocs/export-observability-data/observability-plugin.mdREADME.mddocs/integrate-frameworks/openclaw-plugin.md
{docs/use-adaptive-optimization/**,**/{test,spec,validate}.{rs,py,go,ts,tsx,js},**/validation.{rs,py,go}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Ensure validation and report behavior remains documented and tested
Files:
docs/use-adaptive-optimization/configure.md
README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update README.md to reflect current workspace members and top-level documentation for changes affecting public behavior, bindings, examples, or workspace structure
Files:
README.md
**/README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update relevant crate or package README when that surface changed
Relevant package or crate README.md files must be updated when examples or binding guidance changes
Files:
README.mdintegrations/openclaw/README.md
{README.md,docs/index.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
{README.md,docs/index.md}: Update entry-point docs when examples or reading paths change
README.md or docs/index.md must be updated when entry points change
Files:
README.md
{README.md,docs/index.md,**/README.md}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Update entry-point documentation (README.md, docs/index.md, package READMEs, binding-level source READMEs) whenever public behavior changes
Files:
README.mdintegrations/openclaw/README.md
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use camelCase naming convention for Node.js code
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{rs,go,js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license headers in all Rust, Go, JavaScript, and TypeScript source files using C-style comment syntax
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use
SONAR_IGNORE_START/SONAR_IGNORE_ENDmarkers only for documented false positives that cannot be resolved in code; keep ignored blocks small, add explanatory comments, and require reviewer sign-off
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
**/{integrations,integration,*-integration}/**
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
**/{integrations,integration,*-integration}/**: Keep NeMo Flow optional in framework integrations
Preserve the framework's original behavior when NeMo Flow is absent
Wrap tool and LLM paths at the correct framework boundary
Integration pattern must followdocs/integrate-frameworks/adding-scopes.md
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/README.mdintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/openclaw.plugin.jsonintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
{crates/adaptive/**,python/nemo_flow/{adaptive,plugin}.py,go/nemo_flow/{adaptive,**}/*.go,**/*.{ts,js,wasm}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Keep adaptive config schema, plugin lifecycle, and bindings in sync across crates/adaptive, core, bindings, Python (python/nemo_flow/adaptive.py and python/nemo_flow/plugin.py), Go (go/nemo_flow/adaptive and go/nemo_flow), and Node/WebAssembly helpers
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{js,ts,tsx,jsx,py,rs,go,java,c,cpp,h,cc,cxx,cs,rb,php,swift,kt}
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Changed files must be formatted with the language-native formatter
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If Node.js language surface changed, always run Node.js test target even when Rust core did not change
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{rs,py,js,ts,tsx,go}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
During iteration, prefer
uv run pre-commit run --files <changed files...>for targeted validation
Files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
docs/integrate-frameworks/**/*.md
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Documentation must be updated if activation or usage of the integration changed
Files:
docs/integrate-frameworks/openclaw-plugin.md
**/{config,schema,adaptive}.{yaml,yml,json,ts,tsx,py,go,rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Ensure dynamic config shape matches the documented canonical model in docs/use-adaptive-optimization/configure.md
Files:
integrations/openclaw/src/config.ts
🧠 Learnings (1)
📚 Learning: 2026-05-07T18:04:44.387Z
Learnt from: mnajafian-nv
Repo: NVIDIA/NeMo-Flow PR: 67
File: integrations/openclaw/src/modules.ts:1-2
Timestamp: 2026-05-07T18:04:44.387Z
Learning: In NVIDIA/NeMo-Flow, TypeScript source files should use `//` line comments for SPDX headers (e.g., `// SPDX-FileCopyrightText: ...` and `// SPDX-License-Identifier: ...`) rather than C-style block comments (`/* ... */`). The repo’s copyright checker enforces this mapping, so `//` SPDX headers in `.ts` files should not be flagged as a style violation.
Applied to files:
integrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/config.test.ts
🔇 Additional comments (26)
docs/build-plugins/plugin-configuration-files.md (1)
17-22: LGTM!README.md (1)
148-149: LGTM!docs/export-observability-data/observability-plugin.md (1)
16-21: LGTM!docs/build-plugins/basic-guide.md (1)
14-19: LGTM!docs/use-adaptive-optimization/configure.md (1)
48-53: LGTM!integrations/openclaw/src/modules.ts (1)
24-24: LGTM!docs/integrate-frameworks/openclaw-plugin.md (1)
11-12: LGTM!Also applies to: 70-88, 109-121, 126-142, 150-167, 175-192, 232-233, 269-269, 317-319
integrations/openclaw/openclaw.plugin.json (1)
15-15: LGTM!Also applies to: 23-23, 25-28, 83-109, 110-132, 133-155, 157-157
integrations/openclaw/README.md (1)
1-277: LGTM!integrations/openclaw/src/config.ts (3)
29-46: LGTM!Also applies to: 134-152
88-105: LGTM!
173-196: LGTM!integrations/openclaw/src/hooks-backend.ts (1)
61-66: LGTM!Also applies to: 345-356, 400-414
integrations/openclaw/src/__tests__/live-smoke.test.ts (1)
32-49: LGTM!Also applies to: 123-132
integrations/openclaw/src/__tests__/hooks-backend.test.ts (1)
350-363: LGTM!integrations/openclaw/src/health.ts (2)
38-62: LGTM!Also applies to: 64-104
107-115: LGTM!integrations/openclaw/src/runtime-state.ts (3)
123-155: LGTM!
369-383: LGTM!Also applies to: 437-448
469-487: LGTM!integrations/openclaw/src/__tests__/config.test.ts (6)
29-47: LGTM!
49-68: LGTM!
89-102: LGTM!
196-233: LGTM!
273-306: LGTM!
593-640: LGTM!
willkill07
force-pushed
the
wkk_openclaw-generic-plugin-config
branch
from
6da441f to
e88e890
Compare
Signed-off-by: Will Killian <wkillian@nvidia.com>
willkill07
force-pushed
the
wkk_openclaw-generic-plugin-config
branch
from
e88e890 to
5f63b4e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
integrations/openclaw/src/runtime-state.ts (1)
135-149:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winLet initialization errors override earlier warning-only reasons.
If validation emits a warning and
initialize()later reports error diagnostics,degradedReasonstays pinned to"NeMo Flow plugin host config validation produced warnings". That hides the actionable initialization failure fromnemoFlow.status.reason.Suggested fix
- if ( - activationReport.diagnostics.some((diagnostic) => diagnostic.level === "error") && - degradedReason === undefined - ) { + if (activationReport.diagnostics.some((diagnostic) => diagnostic.level === "error")) { degradedReason = "NeMo Flow plugin host initialization reported errors"; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/openclaw/src/runtime-state.ts` around lines 135 - 149, The current logic prevents initialization errors from overwriting an earlier validation-warning reason; update the activation-report handling so that when modules.pluginHost.initialize(...) returns activationReport with any diagnostic.level === "error" you set degradedReason = "NeMo Flow plugin host initialization reported errors" regardless of degradedReason's current value (i.e., remove the degradedReason === undefined guard around the activationReport error branch), referencing activationReport, modules.pluginHost.initialize, logDiagnostics, and the degradedReason variable in runtime-state.ts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integrations/openclaw/src/health.ts`:
- Around line 46-57: The outputs health must reflect an explicit plugin-host
failure signal instead of relying on initializedPluginHost; compute a boolean
(pluginHostFailed) from params.status.state === "degraded" &&
!params.initializedPluginHost and pass that boolean into outputHealth for each
configured output (the configuredObservabilityOutputs result) so
outputHealth(op, pluginHostFailed) is used for atif, otel, openInference, etc.,
replacing any checks that only used params.initializedPluginHost.
---
Outside diff comments:
In `@integrations/openclaw/src/runtime-state.ts`:
- Around line 135-149: The current logic prevents initialization errors from
overwriting an earlier validation-warning reason; update the activation-report
handling so that when modules.pluginHost.initialize(...) returns
activationReport with any diagnostic.level === "error" you set degradedReason =
"NeMo Flow plugin host initialization reported errors" regardless of
degradedReason's current value (i.e., remove the degradedReason === undefined
guard around the activationReport error branch), referencing activationReport,
modules.pluginHost.initialize, logDiagnostics, and the degradedReason variable
in runtime-state.ts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: c4c8eccc-03ac-495a-b8ca-129cb8c484e8
📒 Files selected for processing (25)
README.mddocs/build-plugins/basic-guide.mddocs/build-plugins/plugin-configuration-files.mddocs/export-observability-data/observability-plugin.mddocs/integrate-frameworks/openclaw-plugin.mddocs/use-adaptive-optimization/configure.mdintegrations/openclaw/README.mdintegrations/openclaw/openclaw.plugin.jsonintegrations/openclaw/package.jsonintegrations/openclaw/src/__tests__/atif-capture.test.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/__tests__/failure-model.test.tsintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/__tests__/llm-replay.test.tsintegrations/openclaw/src/__tests__/telemetry.test.tsintegrations/openclaw/src/__tests__/tool-replay.test.tsintegrations/openclaw/src/atif-capture.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/hook-replay/session.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/telemetry.ts
💤 Files with no reviewable changes (9)
- integrations/openclaw/package.json
- integrations/openclaw/src/tests/atif-capture.test.ts
- integrations/openclaw/src/tests/telemetry.test.ts
- integrations/openclaw/src/telemetry.ts
- integrations/openclaw/src/atif-capture.ts
- integrations/openclaw/src/tests/tool-replay.test.ts
- integrations/openclaw/src/hook-replay/session.ts
- integrations/openclaw/src/tests/llm-replay.test.ts
- integrations/openclaw/src/tests/failure-model.test.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (34)
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst,txt}: SpellNVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as 'here' or 'read more.'
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical documentation.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented documentation unless the source, platform, or legal guidance explicitly requires them.
Do not add trademark symbols to NeMo Flow learning documentation by default.
Do not rewrite API names, package names, command flags, or code literals for style reasons.
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
**/*.{md,markdown,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
**/*.{md,markdown,rst}: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Use monospace formatting for code elements, commands, parameters, package names, and expressions
Use monospace formatting for directories, file names, and paths
Use angle brackets inside monospace for variables inside paths, such as/home/<username>/.login
Use quotation marks for error messages and strings in documentation
Use bold formatting for UI buttons, menus, fields, and labels in documentation
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use in documentation
Use italics for publication titles in documentation
Use plain text formatting for keyboard shortcuts in documentation
Prefer[NVIDIA/NeMo](link)format for GitHub repository references over generic phrases like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text in documentation
Avoid generic link anchors such as 'here,' 'this page,' and 'read more' in documentation
Include the acronym in link text if a linked term includes an acronym
Do not link long sentences or multiple sentences in documentation
Avoid links that pull readers away from a procedure unles...
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
**/*.{html,md}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license headers in HTML and Markdown files using HTML comment syntax
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
docs/**/*.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run
./scripts/build-docs.shfor documentation site changes
docs/**/*.md: Relevant getting-started or reference docs must be updated when examples change
Release-policy docs must point to GitHub Releases as the only release-history source of truth
docs/**/*.md: Use title case for headings in technical documentation
Introduce code blocks, tables, and lists with complete lead-in sentences in documentation
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run Markdown link checking via
lycheeforREADME.md,CONTRIBUTING.md, anddocs/through pre-commit hooks
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
**/*.{md,markdown,py,sh,bash,js,ts,java,cpp,go,rust}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current in documentation
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mdintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsdocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.mdintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
{RELEASING.md,CHANGELOG.md,docs/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep release-process and release-notes guidance in repo-maintainer docs such as RELEASING.md, not as user-facing docs pages or CHANGELOG.md
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,markdown,py,sh,bash}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep stable user-facing wrappers at scripts/ root in docs and examples; only point at namespaced helper paths when documenting internal maintenance work
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
**/*.{md,markdown,py,sh,bash,js,ts,example}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Example commands must match current package names and paths
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mdintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsdocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.mdintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
{scripts/*.sh,docs/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Use root
./scripts/*.shcommands in docs and contributor guidance as documented, with implementations underscripts/third-party/
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
{docs/use-adaptive-optimization/**,**/{test,spec,validate}.{rs,py,go,ts,tsx,js},**/validation.{rs,py,go}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Ensure validation and report behavior remains documented and tested
Files:
docs/use-adaptive-optimization/configure.md
{docs/**,examples/**,crates/adaptive/**,python/nemo_flow/**,go/nemo_flow/**,**/{example,component}.{ts,tsx,js,rs,py,go}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Any new adaptive component kind must have documentation, examples, and binding coverage across all supported languages
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
{README*,CHANGELOG*,docs/**/*.{md,rst,txt},examples/**/*,*.md}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update documentation, examples, and getting-started guides with new package/module/crate names after rename operations
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{md,txt,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
**/*.{md,txt,rst}: Ensure commands, package names, file paths, and APIs in documentation are correct and not stale; flag incorrect or outdated information as blocking issues
Ensure examples and procedures in documentation will execute successfully with current APIs and commands
Use consistent user-facing terminology throughout documentation that matches current repo terminology
Capitalize NVIDIA correctly in all documentation and public-facing text
Format code, commands, paths, and filenames as inline code (monospace) in documentation
Use descriptive anchor text for links instead of bare URLs or weak labels like 'here' in documentation
Prefer active voice, present tense, short sentences, and plain English in documentation
Structure documentation procedures as imperative steps that are easy to scan and not too long for a single sequence
Prefer 'after' instead of 'once' for temporal references in documentation
Use 'can' instead of 'may' when describing possibility (rather than permission) in documentation
Avoid ambiguous numeric dates and ordinal dates in documentation body text
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.md
{README.md,docs/**/*.md,examples/**/*.{js,ts,py,go,rs}}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep documentation and examples synchronized with current install, import, and build commands
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
**/*.{py,js,ts,tsx,go,rs,md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Format changed files with the language-native formatter before the final lint/test pass
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mdintegrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsdocs/integrate-frameworks/openclaw-plugin.mdintegrations/openclaw/README.mdintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
{README.md,CONTRIBUTING.md,docs/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
For docs-only changes, run targeted checks only if commands, package names, or examples changed. Use
just docsfor docs-site builds andjust docs-linkcheckwhen links changed
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency across language bindings.
Flag stale examples, missing SPDX headers where required, and instructions that no longer match CI or pre-commit behavior.
Files:
docs/use-adaptive-optimization/configure.mddocs/build-plugins/basic-guide.mdREADME.mddocs/export-observability-data/observability-plugin.mddocs/build-plugins/plugin-configuration-files.mddocs/integrate-frameworks/openclaw-plugin.md
README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update README.md to reflect current workspace members and top-level documentation for changes affecting public behavior, bindings, examples, or workspace structure
Files:
README.md
**/README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update relevant crate or package README when that surface changed
Relevant package or crate README.md files must be updated when examples or binding guidance changes
Files:
README.mdintegrations/openclaw/README.md
{README.md,docs/index.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
{README.md,docs/index.md}: Update entry-point docs when examples or reading paths change
README.md or docs/index.md must be updated when entry points change
Files:
README.md
{README.md,docs/index.md,**/README.md}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Update entry-point documentation (README.md, docs/index.md, package READMEs, binding-level source READMEs) whenever public behavior changes
Files:
README.mdintegrations/openclaw/README.md
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use camelCase naming convention for Node.js code
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
**/*.{rs,go,js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license headers in all Rust, Go, JavaScript, and TypeScript source files using C-style comment syntax
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use
SONAR_IGNORE_START/SONAR_IGNORE_ENDmarkers only for documented false positives that cannot be resolved in code; keep ignored blocks small, add explanatory comments, and require reviewer sign-off
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
**/{integrations,integration,*-integration}/**
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
**/{integrations,integration,*-integration}/**: Keep NeMo Flow optional in framework integrations
Preserve the framework's original behavior when NeMo Flow is absent
Wrap tool and LLM paths at the correct framework boundary
Integration pattern must followdocs/integrate-frameworks/adding-scopes.md
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/README.mdintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/openclaw.plugin.jsonintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
{crates/adaptive/**,python/nemo_flow/{adaptive,plugin}.py,go/nemo_flow/{adaptive,**}/*.go,**/*.{ts,js,wasm}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Keep adaptive config schema, plugin lifecycle, and bindings in sync across crates/adaptive, core, bindings, Python (python/nemo_flow/adaptive.py and python/nemo_flow/plugin.py), Go (go/nemo_flow/adaptive and go/nemo_flow), and Node/WebAssembly helpers
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
**/*.{js,ts,tsx,jsx,py,rs,go,java,c,cpp,h,cc,cxx,cs,rb,php,swift,kt}
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Changed files must be formatted with the language-native formatter
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If Node.js language surface changed, always run Node.js test target even when Rust core did not change
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
**/*.{rs,py,js,ts,tsx,go}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
During iteration, prefer
uv run pre-commit run --files <changed files...>for targeted validation
Files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
docs/integrate-frameworks/**/*.md
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Documentation must be updated if activation or usage of the integration changed
Files:
docs/integrate-frameworks/openclaw-plugin.md
**/{config,schema,adaptive}.{yaml,yml,json,ts,tsx,py,go,rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Ensure dynamic config shape matches the documented canonical model in docs/use-adaptive-optimization/configure.md
Files:
integrations/openclaw/src/config.ts
🧠 Learnings (1)
📚 Learning: 2026-05-07T18:04:44.387Z
Learnt from: mnajafian-nv
Repo: NVIDIA/NeMo-Flow PR: 67
File: integrations/openclaw/src/modules.ts:1-2
Timestamp: 2026-05-07T18:04:44.387Z
Learning: In NVIDIA/NeMo-Flow, TypeScript source files should use `//` line comments for SPDX headers (e.g., `// SPDX-FileCopyrightText: ...` and `// SPDX-License-Identifier: ...`) rather than C-style block comments (`/* ... */`). The repo’s copyright checker enforces this mapping, so `//` SPDX headers in `.ts` files should not be flagged as a style violation.
Applied to files:
integrations/openclaw/src/__tests__/hooks-backend.test.tsintegrations/openclaw/src/__tests__/live-smoke.test.tsintegrations/openclaw/src/hooks-backend.tsintegrations/openclaw/src/modules.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/config.tsintegrations/openclaw/src/health.ts
🔇 Additional comments (8)
README.md (1)
148-149: LGTM!docs/build-plugins/basic-guide.md (1)
14-19: LGTM!docs/build-plugins/plugin-configuration-files.md (1)
17-22: LGTM!docs/export-observability-data/observability-plugin.md (1)
16-21: LGTM!docs/use-adaptive-optimization/configure.md (1)
48-53: LGTM!integrations/openclaw/src/modules.ts (1)
24-24: LGTM!integrations/openclaw/openclaw.plugin.json (1)
15-28: LGTM!Also applies to: 83-157
docs/integrate-frameworks/openclaw-plugin.md (1)
11-13: LGTM!Also applies to: 55-59, 71-149, 157-175, 191-193, 228-229, 276-279
willkill07
force-pushed
the
wkk_openclaw-generic-plugin-config
branch
from
dbb0269 to
f11b7cb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integrations/openclaw/README.md`:
- Line 149: Replace the raw URL anchor text
"https://nvidia.github.io/NeMo-Flow/" with a descriptive markdown link label
that matches the destination (e.g., "the NeMo Flow documentation" or "NeMo
Flow's Observability Plugin schema documentation") so the sentence reads
naturally and the link text describes the target; update the link in README.md
to use the chosen descriptive text in standard markdown link syntax.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 0750566a-ec49-4a47-8c3a-dc48a1fd2b01
📒 Files selected for processing (1)
integrations/openclaw/README.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Documentation / Build
- GitHub Check: OpenClaw / Test
- GitHub Check: License Diff / Run
🧰 Additional context used
📓 Path-based instructions (14)
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
integrations/openclaw/README.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
integrations/openclaw/README.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst,txt}: SpellNVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as 'here' or 'read more.'
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical documentation.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented documentation unless the source, platform, or legal guidance explicitly requires them.
Do not add trademark symbols to NeMo Flow learning documentation by default.
Do not rewrite API names, package names, command flags, or code literals for style reasons.
Files:
integrations/openclaw/README.md
**/*.{md,markdown,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
**/*.{md,markdown,rst}: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Use monospace formatting for code elements, commands, parameters, package names, and expressions
Use monospace formatting for directories, file names, and paths
Use angle brackets inside monospace for variables inside paths, such as/home/<username>/.login
Use quotation marks for error messages and strings in documentation
Use bold formatting for UI buttons, menus, fields, and labels in documentation
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use in documentation
Use italics for publication titles in documentation
Use plain text formatting for keyboard shortcuts in documentation
Prefer[NVIDIA/NeMo](link)format for GitHub repository references over generic phrases like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text in documentation
Avoid generic link anchors such as 'here,' 'this page,' and 'read more' in documentation
Include the acronym in link text if a linked term includes an acronym
Do not link long sentences or multiple sentences in documentation
Avoid links that pull readers away from a procedure unles...
Files:
integrations/openclaw/README.md
**/*.{html,md}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license headers in HTML and Markdown files using HTML comment syntax
Files:
integrations/openclaw/README.md
**/README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update relevant crate or package README when that surface changed
Relevant package or crate README.md files must be updated when examples or binding guidance changes
Files:
integrations/openclaw/README.md
**/*.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run Markdown link checking via
lycheeforREADME.md,CONTRIBUTING.md, anddocs/through pre-commit hooks
Files:
integrations/openclaw/README.md
**/*.{md,markdown,py,sh,bash,js,ts,java,cpp,go,rust}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current in documentation
Files:
integrations/openclaw/README.md
**/*.{md,markdown,py,sh,bash}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep stable user-facing wrappers at scripts/ root in docs and examples; only point at namespaced helper paths when documenting internal maintenance work
Files:
integrations/openclaw/README.md
**/*.{md,markdown,py,sh,bash,js,ts,example}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Example commands must match current package names and paths
Files:
integrations/openclaw/README.md
**/{integrations,integration,*-integration}/**
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
**/{integrations,integration,*-integration}/**: Keep NeMo Flow optional in framework integrations
Preserve the framework's original behavior when NeMo Flow is absent
Wrap tool and LLM paths at the correct framework boundary
Integration pattern must followdocs/integrate-frameworks/adding-scopes.md
Files:
integrations/openclaw/README.md
**/*.{md,txt,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
**/*.{md,txt,rst}: Ensure commands, package names, file paths, and APIs in documentation are correct and not stale; flag incorrect or outdated information as blocking issues
Ensure examples and procedures in documentation will execute successfully with current APIs and commands
Use consistent user-facing terminology throughout documentation that matches current repo terminology
Capitalize NVIDIA correctly in all documentation and public-facing text
Format code, commands, paths, and filenames as inline code (monospace) in documentation
Use descriptive anchor text for links instead of bare URLs or weak labels like 'here' in documentation
Prefer active voice, present tense, short sentences, and plain English in documentation
Structure documentation procedures as imperative steps that are easy to scan and not too long for a single sequence
Prefer 'after' instead of 'once' for temporal references in documentation
Use 'can' instead of 'may' when describing possibility (rather than permission) in documentation
Avoid ambiguous numeric dates and ordinal dates in documentation body text
Files:
integrations/openclaw/README.md
{README.md,docs/index.md,**/README.md}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Update entry-point documentation (README.md, docs/index.md, package READMEs, binding-level source READMEs) whenever public behavior changes
Files:
integrations/openclaw/README.md
**/*.{py,js,ts,tsx,go,rs,md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Format changed files with the language-native formatter before the final lint/test pass
Files:
integrations/openclaw/README.md
🔇 Additional comments (8)
integrations/openclaw/README.md (8)
1-12: LGTM!
14-33: LGTM!
34-50: LGTM!
52-148: LGTM!
151-174: LGTM!
176-186: LGTM!
188-203: LGTM!
204-237: LGTM!
mnajafian-nv
left a comment
mnajafian-nv
left a comment
There was a problem hiding this comment.
Great work! I added my suggestions inline and currently running various experiments to check the intended behavior is intact
Signed-off-by: Will Killian <wkillian@nvidia.com>
mnajafian-nv
left a comment
mnajafian-nv
left a comment
There was a problem hiding this comment.
Tested PR #102 end to end with examples that exercised LLM calls, tool calls, file reads/writes, ATIF export, and Phoenix/OpenInference export.
Validated:
- OpenClaw plugin config using
plugins.components[{ kind: "observability" }] - ATIF export
- Phoenix traces on
localhost:6008 - Tool spans, LLM spans, token counts, and
openclaw.sessionspan are present
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
integrations/openclaw/src/runtime-state.ts (1)
138-143:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDo not degrade runtime status on warning-only validation diagnostics.
This branch marks startup as
degradedeven when validation only emits warnings andpluginHost.initialize()succeeds. That turns non-fatal config advice into an operator-visible unhealthy state. Warnings are already surfaced bylogDiagnostics(...); reservedegradedfor thrown/error diagnostics.Suggested change
- if ( - validationReport.report.diagnostics.some((diagnostic) => diagnostic.level === "warning") && - degradedReason === undefined - ) { - degradedReason = "NeMo Flow plugin host config validation produced warnings"; - } - try { const activationReport = await modules.pluginHost.initialize(hostConfig);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/openclaw/src/runtime-state.ts` around lines 138 - 143, The code currently sets degradedReason when validationReport.report.diagnostics contains any "warning"; change this so runtime is only marked degraded for error-level diagnostics or thrown errors: in the block that assigns degradedReason (referencing validationReport.report.diagnostics and degradedReason), replace the .some check for "warning" with a check for "error" (or otherwise ensure you only set degradedReason when a diagnostic.level === "error" or when pluginHost.initialize() throws), and keep warnings surfaced via logDiagnostics(...) without flipping the degraded state.
♻️ Duplicate comments (1)
integrations/openclaw/package.json (1)
61-61:⚠️ Potential issue | 🟠 Major | ⚡ Quick winTighten the minimum
nemo-flow-nodeversion for observability compatibility.At Line 61,
>0.1.0 <1.0.0still permits0.1.x, which can be incompatible with this PR’s requiredobservabilityplugin component and lead to degraded runtime on an otherwise “valid” install. Please set the lower bound to the first confirmed observability-capable release (likely>=0.2.0).#!/bin/bash set -euo pipefail # Verify which nemo-flow-node versions contain observability/plugin-kind support. # Read-only: fetch metadata + tarballs, then grep exported artifacts. for v in 0.1.0 0.1.1 0.2.0 0.2.1; do echo "=== nemo-flow-node@$v ===" meta_url="https://registry.npmjs.org/nemo-flow-node/$v" tarball=$(curl -fsSL "$meta_url" | jq -r '.dist.tarball') tmpdir=$(mktemp -d) curl -fsSL "$tarball" -o "$tmpdir/pkg.tgz" tar -xzf "$tmpdir/pkg.tgz" -C "$tmpdir" rg -n --iglob '*.js' --iglob '*.d.ts' 'observability|listKinds|plugin' "$tmpdir/package" || true rm -rf "$tmpdir" done🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/openclaw/package.json` at line 61, Update the nemo-flow-node version range in package.json from ">0.1.0 <1.0.0" to require the first observability-capable release by using ">=0.2.0 <1.0.0" (i.e. change the "nemo-flow-node" dependency string) so installs cannot pull incompatible 0.1.x releases that lack the observability/plugin-kind support.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@integrations/openclaw/src/runtime-state.ts`:
- Around line 138-143: The code currently sets degradedReason when
validationReport.report.diagnostics contains any "warning"; change this so
runtime is only marked degraded for error-level diagnostics or thrown errors: in
the block that assigns degradedReason (referencing
validationReport.report.diagnostics and degradedReason), replace the .some check
for "warning" with a check for "error" (or otherwise ensure you only set
degradedReason when a diagnostic.level === "error" or when
pluginHost.initialize() throws), and keep warnings surfaced via
logDiagnostics(...) without flipping the degraded state.
---
Duplicate comments:
In `@integrations/openclaw/package.json`:
- Line 61: Update the nemo-flow-node version range in package.json from ">0.1.0
<1.0.0" to require the first observability-capable release by using ">=0.2.0
<1.0.0" (i.e. change the "nemo-flow-node" dependency string) so installs cannot
pull incompatible 0.1.x releases that lack the observability/plugin-kind
support.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 182b219d-2736-4f2b-86ac-d9e5836635c2
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
integrations/openclaw/package.jsonintegrations/openclaw/src/__tests__/config.test.tsintegrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (12)
**/{integrations,integration,*-integration}/**
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
**/{integrations,integration,*-integration}/**: Keep NeMo Flow optional in framework integrations
Preserve the framework's original behavior when NeMo Flow is absent
Wrap tool and LLM paths at the correct framework boundary
Integration pattern must followdocs/integrate-frameworks/adding-scopes.md
Files:
integrations/openclaw/package.jsonintegrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
integrations/openclaw/package.json
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
Keep
integrations/openclaw/package.jsonversion aligned with the workspace-rootpackage-lock.jsonunderpackages["integrations/openclaw"].version
Files:
integrations/openclaw/package.json
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use camelCase naming convention for Node.js code
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{rs,go,js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license headers in all Rust, Go, JavaScript, and TypeScript source files using C-style comment syntax
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use
SONAR_IGNORE_START/SONAR_IGNORE_ENDmarkers only for documented false positives that cannot be resolved in code; keep ignored blocks small, add explanatory comments, and require reviewer sign-off
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{md,markdown,py,sh,bash,js,ts,java,cpp,go,rust}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current in documentation
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{md,markdown,py,sh,bash,js,ts,example}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Example commands must match current package names and paths
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
{crates/adaptive/**,python/nemo_flow/{adaptive,plugin}.py,go/nemo_flow/{adaptive,**}/*.go,**/*.{ts,js,wasm}}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Keep adaptive config schema, plugin lifecycle, and bindings in sync across crates/adaptive, core, bindings, Python (python/nemo_flow/adaptive.py and python/nemo_flow/plugin.py), Go (go/nemo_flow/adaptive and go/nemo_flow), and Node/WebAssembly helpers
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{js,ts,tsx,jsx,py,rs,go,java,c,cpp,h,cc,cxx,cs,rb,php,swift,kt}
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Changed files must be formatted with the language-native formatter
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If Node.js language surface changed, always run Node.js test target even when Rust core did not change
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{py,js,ts,tsx,go,rs,md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Format changed files with the language-native formatter before the final lint/test pass
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
**/*.{rs,py,js,ts,tsx,go}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
During iteration, prefer
uv run pre-commit run --files <changed files...>for targeted validation
Files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
🧠 Learnings (1)
📚 Learning: 2026-05-07T18:04:44.387Z
Learnt from: mnajafian-nv
Repo: NVIDIA/NeMo-Flow PR: 67
File: integrations/openclaw/src/modules.ts:1-2
Timestamp: 2026-05-07T18:04:44.387Z
Learning: In NVIDIA/NeMo-Flow, TypeScript source files should use `//` line comments for SPDX headers (e.g., `// SPDX-FileCopyrightText: ...` and `// SPDX-License-Identifier: ...`) rather than C-style block comments (`/* ... */`). The repo’s copyright checker enforces this mapping, so `//` SPDX headers in `.ts` files should not be flagged as a style violation.
Applied to files:
integrations/openclaw/src/health.tsintegrations/openclaw/src/runtime-state.tsintegrations/openclaw/src/__tests__/config.test.ts
Signed-off-by: Will Killian <wkillian@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@justfile`:
- Around line 1078-1083: The project version update flow is missing the new
nemo-flow-node package field so running set-version can leave
integrations/openclaw stale; update the helper functions so set_project_version
and set_node_package_versions include the nemo-flow-node dependency mutation
(align with the added set_npm_package_dependency_version invocation), keep
set_node_package_version as a compatibility alias, and ensure
set_npm_package_version remains the reusable JSON helper used by
set_node_package_versions; adjust the lists/fields in set_project_version,
set_cargo_workspace_version, and set_node_package_versions to include the
nemo-flow-node entry so all targets (including integrations/openclaw) are
updated together.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: ca360298-55fe-459f-8f5d-f48b8fa1b3e9
📒 Files selected for processing (1)
justfile
📜 Review details
🧰 Additional context used
📓 Path-based instructions (2)
justfile
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
When editing helper code, keep
set_project_version,set_cargo_workspace_version, andset_node_package_versionsaligned with version-update fields; maintainset_node_package_versionas a compatibility alias andset_npm_package_versionas the reusable npm JSON helper
Files:
justfile
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}
⚙️ CodeRabbit configuration file
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}: Review automation changes for reproducibility, pinned versions where appropriate, secret handling, and consistency with the documented validation matrix.
Pay attention to commands that need generated native artifacts, FFI libraries, or platform-specific environment variables.
Files:
justfile
🔇 Additional comments (1)
justfile (1)
316-392: LGTM!Also applies to: 1070-1076
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
/merge |
1 similar comment
|
/merge |
3 participants
Overview
Pivot the OpenClaw NeMo Flow plugin to use the generic NeMo Flow plugin initialization document under
config.plugins. This is a breaking configuration change that removes the OpenClaw-specific exporter sections and routes exporter setup through the built-inobservabilityplugin component.Details
pluginsdocument.atif,telemetry, andnemoFlow.pluginConfigwith migration errors.nemo-flow-node/plugin.initializeand degrade runtime health when plugin-host validation or initialization fails.nemoFlow.statusoutput health from configured generic observability components.snake_case.Where should the reviewer start?
Start with
integrations/openclaw/src/config.tsfor the new wrapper shape, thenintegrations/openclaw/src/runtime-state.tsfor generic plugin-host validation and initialization behavior. The E2E coverage is inintegrations/openclaw/src/__tests__/config.test.ts.Validation run:
npm run build --workspace=nemo-flow-openclawnpm run typecheck --workspace=nemo-flow-openclawnpm test --workspace=nemo-flow-openclawnpm run pack:check --workspace=nemo-flow-openclawjust docsRelated Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Documentation
Refactor
Tests
Chores