Skip to content

fix(cli): preserve symlinks during sandbox upload#1561

Open
mjamiv wants to merge 1 commit into
NVIDIA:mainfrom
mjamiv:fix/upload-preserve-symlinks
Open

fix(cli): preserve symlinks during sandbox upload#1561
mjamiv wants to merge 1 commit into
NVIDIA:mainfrom
mjamiv:fix/upload-preserve-symlinks

Conversation

@mjamiv
Copy link
Copy Markdown
Contributor

@mjamiv mjamiv commented May 25, 2026

Summary

  • build sandbox upload archives with symlink metadata instead of following links
  • preserve symlink entries for whole-directory and git-style file-list uploads
  • keep existing directory archive shape and file-list missing-entry behavior

Fixes #1425.

Testing

  • cargo fmt --all -- --check
  • git diff --check
  • cargo test -p openshell-cli archive_preserves_symlink
  • cargo test -p openshell-cli

@mjamiv mjamiv requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 25, 2026 21:50
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 25, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sandbox upload dereferences symlinks — uploaded as real directories, breaking git

1 participant