Skip to content

Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test#2199

Merged
rwgk merged 2 commits into
NVIDIA:mainfrom
rwgk:nvshmem_pin
Jun 11, 2026
Merged

Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test#2199
rwgk merged 2 commits into
NVIDIA:mainfrom
rwgk:nvshmem_pin

Conversation

@rwgk

@rwgk rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a !=3.7.0 exclusion to the CUDA 12 and CUDA 13 NVSHMEM test dependencies.
  • Keep pathfinder CI from selecting an NVSHMEM package release that does not provide the expected libnvshmem_device.bc file.

@rwgk rwgk added this to the cuda.pathfinder next milestone Jun 11, 2026
@rwgk rwgk self-assigned this Jun 11, 2026
@rwgk rwgk added P0 High priority - Must do! cuda.pathfinder Everything related to the cuda.pathfinder module labels Jun 11, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@rwgk rwgk marked this pull request as ready for review June 11, 2026 17:00
@rwgk rwgk requested a review from seberg June 11, 2026 17:00

@seberg seberg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, hopefully we have cleared this up one way or another by the time 3.7.1 hits :).

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

This comment has been minimized.

@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label Jun 11, 2026
@rwgk rwgk enabled auto-merge (squash) June 11, 2026 19:01
@mdboom mdboom changed the title Exclude NVSHMEM 3.7.0 from pathfinder test dependencies Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test Jun 11, 2026
@rwgk rwgk merged commit bd2dc6c into NVIDIA:main Jun 11, 2026
104 checks passed
@rwgk rwgk deleted the nvshmem_pin branch June 11, 2026 19:51
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants