Skip to content

Tweak testing instructions in CONTRIBUTING.md#1000

Merged
rapids-bot[bot] merged 2 commits intomainfrom
mlubin-patch-1
Mar 31, 2026
Merged

Tweak testing instructions in CONTRIBUTING.md#1000
rapids-bot[bot] merged 2 commits intomainfrom
mlubin-patch-1

Conversation

@mlubin
Copy link
Copy Markdown
Contributor

@mlubin mlubin commented Mar 30, 2026

The instructions fail for me without ./.

WAYPOINT_MATRIXTEST fails with an obscure error if CUOPT_HOME isn't exported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c681a1a6-ff2b-481a-87d0-653ebd8e09a5

📥 Commits

Reviewing files that changed from the base of the PR and between e8d8e70 and c7b3610.

📒 Files selected for processing (1)
  • CONTRIBUTING.md
✅ Files skipped from review due to trivial changes (1)
  • CONTRIBUTING.md

📝 Walkthrough

Walkthrough

Updated CONTRIBUTING.md example: changed shell assignment to an exported environment variable export CUOPT_HOME=... and updated test-data download command examples to invoke ./get_test_data.sh explicitly after cd $CUOPT_HOME/datasets/.

Changes

Cohort / File(s) Summary
Documentation
CONTRIBUTING.md
Replaced non-exported CUOPT_HOME=... assignment with export CUOPT_HOME=...; changed get_test_data.sh invocations to explicit ./get_test_data.sh after cd $CUOPT_HOME/datasets/ in C++ and Python test examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Tweak testing instructions in CONTRIBUTING.md' accurately describes the main changes to the pull request, which involve updating setup and test instructions in the CONTRIBUTING.md file.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific issues that motivated the changes: missing './' prefix and missing 'export' for CUOPT_HOME in the instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mlubin-patch-1

Comment @coderabbitai help to get the list of available commands and usage tips.

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Thank you @mlubin for the corrections, please update or provide suggestions to improve the docs as you are on-boarding.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 31, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mlubin mlubin added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Mar 31, 2026
@mlubin
Copy link
Copy Markdown
Contributor Author

mlubin commented Mar 31, 2026

/ok to test c7b3610

@rg20
Copy link
Copy Markdown
Contributor

rg20 commented Mar 31, 2026

@rgsl888prabhu there was no reviewer assigned automatically for this one. Is that expected? @anandhkb for viz!

@rg20
Copy link
Copy Markdown
Contributor

rg20 commented Mar 31, 2026

Congrats @mlubin on your first PR!

@mlubin
Copy link
Copy Markdown
Contributor Author

mlubin commented Mar 31, 2026

/merge

@rapids-bot rapids-bot bot merged commit 39b3b47 into main Mar 31, 2026
76 checks passed
@mlubin mlubin deleted the mlubin-patch-1 branch March 31, 2026 18:30
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

@rgsl888prabhu there was no reviewer assigned automatically for this one. Is that expected? @anandhkb for viz!

May be that's because it touched markdown files. Let me fix that issue.

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

@rg20 This should fix the issue #1013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants