Fix duplicate libmps_parser.so in libcuopt wheel#1092
Open
rgsl888prabhu wants to merge 1 commit intomainfrom
Open
Fix duplicate libmps_parser.so in libcuopt wheel#1092rgsl888prabhu wants to merge 1 commit intomainfrom
rgsl888prabhu wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated CMake install for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The mps_parser install in libmps_parser/CMakeLists.txt hardcoded `DESTINATION lib` while the parent cuopt CMakeLists.txt installs to the platform-correct lib directory (lib64 on x86_64) via rapids_cmake_install_lib_dir(). This caused libmps_parser.so to appear in both lib/ and lib64/ in the wheel, wasting ~350 KB. Use rapids_cmake_install_lib_dir() to resolve the correct library directory, eliminating the duplicate.
00c4500 to
208d3bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mps_parserinstall target incpp/libmps_parser/CMakeLists.txthardcodedDESTINATION lib, while the parentcpp/CMakeLists.txtinstalls to the platform-correctlib64(on x86_64) viarapids_cmake_install_lib_dir(). This causedlibmps_parser.soto appear in bothlib/andlib64/in the libcuopt wheel, wasting ~350 KB.libwithrapids_cmake_install_lib_dir()so both install commands resolve to the same directory, eliminating the duplicate.Details
In the current
libcuopt_cu13wheel (libcuopt_cu13-26.6.0a103),libmps_parser.so(357,240 bytes) appears twice:The root cause is two independent
install(TARGETS mps_parser ...)commands:cpp/libmps_parser/CMakeLists.txt:139→DESTINATION lib(hardcoded)cpp/CMakeLists.txt:576→DESTINATION ${_LIB_DEST}→lib64(viarapids_cmake_install_lib_dir)Test plan
libmps_parser.soinlib64/, not inlib/mps_parserbuild still installs to the correct platform lib directorycuopt-mps-parserPython wheel build is unaffected (usesEXCLUDE_FROM_ALL+ custom destinations)🤖 Generated with Claude Code