Skip to content

Return error for invalid runtime datatypes#3339

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix-runtime-datatype-validation
Open

Return error for invalid runtime datatypes#3339
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix-runtime-datatype-validation

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • Return Status::kErrorInvalidProblem when runtime datatype A/B values are not found in the 3.x GEMM runtime datatype mapping.
  • Apply the same validation to GEMM, blockwise GEMM, and sparse GEMM update paths.
  • Avoid relying on assert("..."), which always evaluates true for string literals.

Testing

  • git diff --check
  • rg -n "assert\\(\\s*\\\"invalid runtime argument for datatype" tools/library/src/gemm_operation_3x.hpp tools/library/src/blockwise_gemm_operation_3x.hpp tools/library/src/sparse_gemm_operation_3x.hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant