chore: separate metrics and telemetry#2056
Merged
Merged
Conversation
9 tasks
yoks
changed the title
kensimon
reviewed
Jun 2, 2026
kensimon
approved these changes
Jun 2, 2026
bryan-aguilar
approved these changes
Jun 2, 2026
nvjaxzin
reviewed
Jun 2, 2026
Comment on lines
+491
to
+495
| _ => Ok(Response::builder() | ||
| .status(http::StatusCode::OK) | ||
| .header(CONTENT_TYPE, "text/plain; charset=utf-8") | ||
| .body("not found; use /metrics, /telemetry, or /livez".to_string()) | ||
| .expect("BUG: Response::builder error")), |
There was a problem hiding this comment.
Based on the body text, should this return 404 instead of OK/200?
Contributor
Author
There was a problem hiding this comment.
Good point, i explicitly made it Ok, so liveness probes which defaults to / would still work. This seems like a safer choice for existing envs which uses / for liveness/ready probes already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits Health service prometheus endpoint between /metrics and /telemetry.
Also removes backward compatability
/endpoint for metrics, as it was confusing and abused via health probes.This issue was raised after discussion on PR #1975
Type of Change
Related Issues (Optional)
Breaking Changes
Telemetry no longer exposed on
/metricsDefault
/endpoint no longer exposes metricsTesting
Additional Notes