Validate that the ARM64 binaries are 64KB page size compatible#2251
Conversation
Signed-off-by: Stoo Davies <189670495+stoo-davies@users.noreply.github.com>
Signed-off-by: Stoo Davies <189670495+stoo-davies@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Stoo Davies <189670495+stoo-davies@users.noreply.github.com>
|
Output from the checks in this PR. The script allows for checking more than 1 path per binary, so it's expected to get some SKIP messages... |
|
I'm ok with the script, but I'd lightly suggest, and you can ignore, that you should just structure the actual check in the justfile/makefile as a post-build step, rather than building into each of the build steps, that is, create a "page check" target that has a pre-requisite of the build steps you've modified, and have the calling target call that one instead. it makes it far easier to see what places need this, and it's easier to use it again later, if we build more things, rather than having to remember to inject this script into each calling location. |
Description
Issue 334 requests that all ARM64 binaries support kernels with 64KB page sizes.
That appears to be the default in the linker that rust is using, and the built in linker that go uses. We also don't appear to be directly calling any system calls that would require page size or page aligned buffers.
This PR adds some validation to the build process, to check the compatibility after compile.
Type of Change
Related Issues (Optional)
#334
Breaking Changes
Testing
Additional Notes