fix: admin cli: display Associated Switch in ew show#2280
Open
sydneyl-nvidia wants to merge 2 commits into
Open
fix: admin cli: display Associated Switch in ew show#2280sydneyl-nvidia wants to merge 2 commits into
sydneyl-nvidia wants to merge 2 commits into
Conversation
forge-admin-cli ew show (expected-switch show) will show "Unlinked" as Associated Machine for every expected switch in normal circumstances, even when switches are fully discovered and ingested. This is due to a CLI lookup bug. Root cause is the code that determines the content of Associated Machine is trying to lookup machines with a bmc MAC, and this will never return a thing. We should be looking up switches instead with this mac. Also, changing the label from Associated Machine to Associated Switch since it is more accurate label for what is being displayed. Signed-off-by: Syd Logan <sydneyl@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
chet
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forge-admin-cli ew show (expected-switch show) will show "Unlinked" as Associated Machine for every expected switch in normal circumstances, even when switches are fully discovered and ingested. This is due to a CLI lookup bug.
Root cause is the code that determines the content of Associated Machine is trying to lookup machines with a bmc MAC, and this will never return a thing. We should be looking up switches instead with this mac.
Also, changing the label from Associated Machine to Associated Switch since it is more accurate label for what is being displayed.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes