feat: Surface Flow task report on Task API#2288
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-2288.docs.buildwithfern.com/infra-controller |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-06-07 18:46:44 UTC | Commit: fe67fc1 |
Task.report bodies can be several KB. Always returning them on ListTasks would persist the blob in every caller-side Temporal activity / workflow payload along the call path, even when the caller never reads it. Opt callers in via with_report, defaulting to off for list endpoints; single-task RPCs always return it. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
Pulls in the new ListTasksRequest.with_report field along with prior upstream drift (Task.report, override_assignment_check on the rack power / firmware / bring-up requests, and refreshed doc comments) that earlier PRs landed without running flow-proto + flow-protogen. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
Surfaces the structured execution report Flow already produces on Task. Single-task GET and Cancel always include it; the rack/tray list endpoints accept withReport=true and forward the flag down to Flow's ListTasksRequest so the multi-KB payload is not paid for on the default list path. The report is exposed as an opaque JSON document with a typed version anchor; clients must branch on version before reading anything else, so Flow's internal schema can evolve without breaking REST consumers. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
Covers 82626a9 (the task report + withReport spec change). Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
kunzhao-nv
force-pushed
the
feat/rest-api-task-report
branch
from
fe67fc1 to
3aa6e8b
Compare
1 participant
Description
report(already produced by Flow) to the rack Task endpoints.GET /rack/task/{id}andPOST /rack/task/{id}/cancelalways include the report. The two list endpoints (/rack/{id}/task,/tray/{id}/task) take a newwithReport=trueopt-in.with_reportis plumbed all the way down toflow.ListTasksRequest, so Flow drops the multi-KB blob server-side when the caller hasn't asked for it; the savings cover the full Temporal workflow / activity payload chain, not just the wire response.reportis exposed as an opaque JSON object with a typedversion: int32anchor; clients must branch onversionbefore reading the body, so Flow's internal report schema can evolve without a breaking change here.Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes