minor: align the target name in conanfile with the document #1730
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericniebler
reviewed
Jan 11, 2026
Comment on lines
58
to
+60
| self.cpp_info.set_property("cmake_file_name", "P2300") | ||
| self.cpp_info.set_property("cmake_target_name", "P2300::P2300") | ||
| self.cpp_info.set_property("cmake_target_aliases", ["STDEXEC::stdexec"]) |
Collaborator
There was a problem hiding this comment.
i'm no conan expert myself, but what do the two lines above yours do? there is no "P2300" file or "P2300::P2300" target.
Contributor
Author
There was a problem hiding this comment.
@ericniebler Sorry for late replay.
It is a minor issue. Let me explain:
1, self.cpp_info.set_property("cmake_file_name", "P2300")
self.cpp_info.set_property("cmake_target_name", "P2300::P2300")
The cmake target name of execution is STDEXEC::stdexec. It was declared as P2300::P2300 in the conanfile years ago. Conan will generate a Find-P2300.cmake, wiht the target name P2300::P2300.
2, self.cpp_info.set_property("cmake_target_aliases", ["STDEXEC::stdexec"])
Adding an alias(STDEXEC::stdexec) of cmake target for execution
Collaborator
|
/ok to test 37e4d45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.