feat: add electron-builder command to publish electron-builder.js#222
feat: add electron-builder command to publish electron-builder.js#222blumewas wants to merge 1 commit intoNativePHP:mainfrom
Conversation
|
@blumewas can you describe more specifically what you're modifying in the |
|
Hey @simonhamp, I also wrote a command merging parts of the native-php config file into the returned JS of the electron-builder but found that part rather complex. So I came up with this simpler solution. To conclude I would say that I am trying to give devs a way to customize the electron-builder config for some use cases that are not required for everybody. If this feels kinda hacky to you which it is because it may only be used if you know what to do I understand if you would reject it. |
|
What specific changes are you trying to make to your |
|
Currently I had no chance to dig that deep into the project. The PR was premature so I’ll close it. For me personally there is NO need atm. |
Add
native:electron-buildercommand to make theelectron-builder.jsfile publishable to our resources directory. This would solve my need as a developer to make changes to backend building step.The command creates a copy of the
electron-builder.jsprovided by installing this package inside theresources/vendor/nativephp/js. After that I will create a backup of thepackage.jsonand updates the scripts section so that our copy will be used when building.When running the command with the
--restoreoption thepackage.jsonwill be restored from a backup.