feat: add Azure code signing configuration#235
Merged
simonhamp merged 2 commits intoNativePHP:mainfrom Jul 26, 2025
Merged
Conversation
Add support for Azure code signing in Electron builder configuration. Includes environment variables for publisher name, endpoint, certificate profile name, and code signing account name. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add support for Azure Trusted Signing by including necessary environment variables in the build process. This enables code signing for Windows applications using Azure's Trusted Signing service. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@simonhamp results from a GitHub Actions run with these changes (running off of my fork). Previously it would say 
|
Contributor
Author
|
@simonhamp I've just verified that our builds that previously got flagged as |
Member
|
Did you changed the .ts file or just the .js file? |
Contributor
Author
|
I only modified https://www.electron.build/code-signing-win.html#using-azure-trusted-signing-beta |
Member
|
Ah maybe there isn't a .ts version of that... ignore me |
simonhamp
approved these changes
Jul 21, 2025
gwleuverink
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Azure code signing in Electron builder configuration. Includes environment variables for publisher name, endpoint, certificate profile name, and code signing account name.
🤖 Generated with Claude Code