Conversation
cd4caac to
8ea85a3
Compare
DominikPalo
approved these changes
Mar 24, 2026
m-kovac
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #454. Fixes #453.
Bug fix
The
DocumentEvents2_SinkHelper.ContentControlBeforeContentUpdatemethod had a copy-paste bugwhere it called
Validate("ContentControlBeforeStoreUpdate")instead ofValidate("ContentControlBeforeContentUpdate").Because the validation used the wrong event name, the event handler would never find
registered delegates for the
ContentControlBeforeContentUpdateevent. This causedthe COM event parameters (specifically the
contentControldispatch object) to bereleased prematurely via
ReleaseParamsArrayon every call, instead of being properlydispatched to user code. The result was a memory leak, as the underlying COM objects
were not properly managed by the event handler lifecycle.
The fix corrects the event name string passed to
Validate()so that theContentControlBeforeContentUpdateevent is properly matched and dispatched to subscribers.Changes
Validate()call inContentControlBeforeContentUpdateto use the correct event nameDocumentEvents2_SinkHelperto verify the fix