Feat: allow user set custom ports for Nginx and Web UI#5212
Open
beniamin wants to merge 1 commit intoNginxProxyManager:developfrom
Open
Feat: allow user set custom ports for Nginx and Web UI#5212beniamin wants to merge 1 commit intoNginxProxyManager:developfrom
beniamin wants to merge 1 commit intoNginxProxyManager:developfrom
Conversation
beniamin
force-pushed
the
custom-ports
branch
from
24737e9 to
de2ea7e
Compare
beniamin
force-pushed
the
custom-ports
branch
from
de2ea7e to
f367046
Compare
…host network where some other services may already use 80,443,81 ports
beniamin
force-pushed
the
custom-ports
branch
from
f367046 to
d95863d
Compare
beniamin
changed the title
|
Docker Image for build 4 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
beniamin
changed the title
jc21
reviewed
Feb 18, 2026
| do | ||
| echo "- ${FILE}" | ||
| # Replace HTTP port | ||
| sed -i -E "s/listen 80([^0-9]|$)/listen ${HTTP_PORT}\1/g" "$FILE" |
Member
There was a problem hiding this comment.
I see what you're trying to do here and I'm glad you thought of this. Something I would consider though..
This script runs on each startup, yet it seems like a run-once migration. Some options that might be better:
- create a migration, they're not just for databases. In this case it could iterate over all hosts and regenerate their nginx config, however there are risks doing this too
- Or keep this file but don't be specific with 80/443. Consider what should happen if I change to 8080/8443 and then change to 8888/9999. I'd expect this script to handle it
Option 2 is probably my preference here.
jc21
added
enhancement
requires-verification
Member
|
Thanks for the work on this! It's been on my mind to do this for a while... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest versions of TrueNAS have been migrated the Apps from k8s to docker and nginx-proxy-manager is the recommended way(in multiple discussion) to be used as a proxy for internal applications. For the setup to be secure and Nginx-proxy-manager to properly forward the traffic to the internal apps, it must be deployed using host_network options.
There are several issues on TrueNAS Apps Catalog repo([Enhancement]: Nginx Proxy Manager - host network and Allow Host Networking for Nginx Proxy Manager) asking for possibility to set nginx-proxy-manager with host_network, but since 80,443 and 81 ports may conflict with other running services on the server, TrueNAS admin require that nginx-proxy-manager should have the possibility to to use custom ports instead of default ones.
This PR change current behavior and adds option for default ports to be changed trough HTTP_PORT, HTTPS_PORT and WEB_UI_PORT environment variables.