chore(deps): bump EuroDNS plugin and fix endpoint url#5535
Conversation
|
Perhaps only the CI/CD Pipeline is interesting since the dependencies are getting bumped in the latest commits. |
|
Okay... this might be more fitting. |
|
Thanks for the contribution, but I do not want to use github workflows at all. CI/CD is hosted at ci.nginxproxymanager.com. Please remove it and keep the PR focussed on a single problem; updating the dns plugin. Thanks! |
Reverted the CI/CD and the Dependabot changes. What about the lockfiles and year increment? |
| { | ||
| "name": "nginx-proxy-manager", | ||
| "version": "2.0.0", | ||
| "version": "2.14.1", |
There was a problem hiding this comment.
This is unnessessary, CI/CD will update this value at deployment time using the .version file in the root of this project.
| { | ||
| "name": "nginx-proxy-manager", | ||
| "version": "2.0.0", | ||
| "version": "2.14.1", |
There was a problem hiding this comment.
Not to be blunt, but is there a downside to having it roughly pinned? Curious if anything...
The year is fine, the package.json and lock files aren't required. I just did a full dependancy update yesterday and Dependabot made a lot of sub-dependency changes too. |
Most of the changes came from me doing it all literally a couple days before you did it. If you want I can revert the changes. |
|
I don't know when you get the time to recheck this PR but I am going to completely rebuild it and force push it in this pr. All to apply the feedback. |
|
@jc21 I force pushed to what might be relevant. |
|
Docker Image for build 7 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
No description provided.