Skip to content

chore(deps): bump EuroDNS plugin and fix endpoint url#5535

Open
DaanSelen wants to merge 1 commit into
NginxProxyManager:developfrom
DaanSelen:develop
Open

chore(deps): bump EuroDNS plugin and fix endpoint url#5535
DaanSelen wants to merge 1 commit into
NginxProxyManager:developfrom
DaanSelen:develop

Conversation

@DaanSelen
Copy link
Copy Markdown

No description provided.

@DaanSelen DaanSelen marked this pull request as draft May 13, 2026 09:30
@DaanSelen
Copy link
Copy Markdown
Author

Perhaps only the CI/CD Pipeline is interesting since the dependencies are getting bumped in the latest commits.

@DaanSelen DaanSelen marked this pull request as ready for review May 13, 2026 14:32
@DaanSelen DaanSelen changed the title Dependency bump and Pipeline addition fix: eurodns plugin and Docker pipeline May 13, 2026
@DaanSelen DaanSelen changed the title fix: eurodns plugin and Docker pipeline fix: eurodns plugin and feat: Docker pipeline May 13, 2026
@DaanSelen
Copy link
Copy Markdown
Author

Okay... this might be more fitting.

@jc21
Copy link
Copy Markdown
Member

jc21 commented May 13, 2026

Thanks for the contribution, but I do not want to use github workflows at all. CI/CD is hosted at ci.nginxproxymanager.com.

Please remove it and keep the PR focussed on a single problem; updating the dns plugin. Thanks!

@DaanSelen
Copy link
Copy Markdown
Author

Thanks for the contribution, but I do not want to use github workflows at all. CI/CD is hosted at ci.nginxproxymanager.com.

Please remove it and keep the PR focussed on a single problem; updating the dns plugin. Thanks!

Reverted the CI/CD and the Dependabot changes. What about the lockfiles and year increment?

Comment thread backend/package.json Outdated
{
"name": "nginx-proxy-manager",
"version": "2.0.0",
"version": "2.14.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnessessary, CI/CD will update this value at deployment time using the .version file in the root of this project.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this.

Comment thread docker/Dockerfile
Comment thread frontend/package.json Outdated
{
"name": "nginx-proxy-manager",
"version": "2.0.0",
"version": "2.14.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same version logic as above

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be blunt, but is there a downside to having it roughly pinned? Curious if anything...

@jc21
Copy link
Copy Markdown
Member

jc21 commented May 14, 2026

Reverted the CI/CD and the Dependabot changes. What about the lockfiles and year increment?

The year is fine, the package.json and lock files aren't required. I just did a full dependancy update yesterday and Dependabot made a lot of sub-dependency changes too.

@DaanSelen
Copy link
Copy Markdown
Author

The year is fine, the package.json and lock files aren't required. I just did a full dependancy update yesterday and Dependabot made a lot of sub-dependency changes too.

Most of the changes came from me doing it all literally a couple days before you did it. If you want I can revert the changes.

@DaanSelen
Copy link
Copy Markdown
Author

I don't know when you get the time to recheck this PR but I am going to completely rebuild it and force push it in this pr.

All to apply the feedback.

@DaanSelen
Copy link
Copy Markdown
Author

@jc21 I force pushed to what might be relevant.

@nginxproxymanagerci
Copy link
Copy Markdown

Docker Image for build 7 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5535

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

@DaanSelen DaanSelen changed the title fix: eurodns plugin and feat: Docker pipeline chore(deps): bump EuroDNS plugin and fix endpoint url May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants