Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Change: fix cmds async execution#2

Open
isirode wants to merge 1 commit intoNobleMajo:mainfrom
isirode:feature/fix-async-cmds
Open

Change: fix cmds async execution#2
isirode wants to merge 1 commit intoNobleMajo:mainfrom
isirode:feature/fix-async-cmds

Conversation

@isirode
Copy link
Copy Markdown

@isirode isirode commented Apr 13, 2023

Hello,

I've noticed that the execution order of the sub commands was not working correctly for my use case.

  • The command was returning even though I had put an await in the 'exe' of the sub command

After taking a look at the code, I figure that it was caused by the fact the 'res.cmd.exe(res)' code line is not awaited.

Changes:

  • Correction of the res.cmd.exe code line
  • Adding tests so that the execution order is tested (tests are not passing without the fix)
  • Incrementation of the version according to SemVer
  • Modification of the package-lock.json : that must had happen in the npm install, not intentionnal

I've noticed that you have a branch 'feature/v2', which look like a full rework.

Are you still working on it ?

I've noticed a few bugs in your documentation, I will wait for the answer to this PR before pushing the fixes,in another PR.

Thanks in advance,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant