feat(i18n): add force option to setLocalLang #622
Merged
+61
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4e8f85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7amed3li
force-pushed
the
feat/i18n-force-option
branch
from
cc6aa93 to
3fba6a5
Compare
7amed3li
force-pushed
the
feat/i18n-force-option
branch
from
3fba6a5 to
a4e8f85
Compare
fraxken
approved these changes
Jan 31, 2026
clemgbld
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #620
Added an optional
forceparam to setLocalLang. If set totrue, it returns getLocalLang() immediately, which updatesCONSTANTS.LANG_UPDATED.This saves us from having to call getLocalLang() manually right after setting the language. Added tests to cover this.