#467 - add duplicate time check and maintain sort array for deleting data keys#516
Open
#467 - add duplicate time check and maintain sort array for deleting data keys#516
Conversation
suryatho
previously approved these changes
Feb 10, 2026
| let lo = 0; | ||
| let hi = arr.length; | ||
| while (lo < hi) { | ||
| const mid = (lo + hi) >>> 1; |
Contributor
There was a problem hiding this comment.
Shift right while also flooring 😃
…te removal in graph.component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added time based range to graph screen (now set as default, with a toggle to switch to point based range). Ultimately it forced a change to data tracking in the graph-page component, which was never really needed (duplication of tracked data, which wouldn't leak, but contributed to more memory usage). Because of that I changed the data type slightly to only be observable in the part that needed observation - the data (via an ObservableGraphInfo interface)
Notes
The double data tracking was contributing to likely double the points being rendered in live mode. Which ultimately exposed a problem that would cause incorrect graphing if we ever got out of order points, now we have support for that edge case (via a binary insertion).
Also for another ticket I would like to now support dynamic refresh rate for slower laptops (or maybe if you are rendering longer periods of data in live mode)
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.jsonchanges (unless dependencies have changed)Closes #467