3776 maintenence Description field for rr by porpol · Pull Request #3962 · Northeastern-Electric-Racing/FinishLine

porpol · 2026-02-08T10:14:10Z

Changes

Backend:

Added description field to reimbursement requests in prisma schema
Reimbursement request create/edit service functions can create/edit descriptions

Frontend:

Added description input field to reimbursement request form
Added description field to reimbursement request table search queries
Added description column and description tooltips to reimbursement request table

Screenshots

Before:

RR table

RR view modal

RR edit

RR create

After:

RR table

RR view modal

RR edit

RR create

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

Closes #3776

…hema

…cing/FinishLine into 3776-maintenence---description-field-for-rr

…ield

…ices

cielbellerose

a few updates but this looks so good, great work!!

cielbellerose · 2026-02-10T01:54:28Z

src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx

+                      fontWeight: 'bold'
+                    }}
+                  >
+                    Input Description


could we update this to just 'Description'?

cielbellerose · 2026-02-10T01:59:48Z

src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx

            {/* Right Column */}
            <Grid item xs={12} md={6}>
              <Stack spacing={3}>
+                {/* Description */}


could we move this to the bottom of the right column? I'm thinking since the Account Code field is required and Upload Receipts is potentially required, it might be more intuitive to have those first

cielbellerose · 2026-02-10T02:09:56Z

src/backend/src/prisma/schema.prisma

  dateCreated              DateTime                        @default(now())
  dateDeleted              DateTime?
  dateOfExpense            DateTime?
+  description              String


we should make this nullable to work with the existing reimbursement requests

cielbellerose · 2026-02-10T02:10:17Z

src/backend/src/prisma/migrations/20260208090936_made_description_not_optional/migration.sql

+
+*/
+-- AlterTable
+ALTER TABLE "Reimbursement_Request" ALTER COLUMN "description" SET NOT NULL;


could we merge these two files into one migration? should work by deleting them and running yarn prisma:migrate again

StephSayegh · 2026-02-10T16:26:38Z

Other than the changes Kinsey said, the rest looks good me!

…optional

…ion is null

cielbellerose

lgtm!

chpy04

Couple changes, also can you make sure that if you upload files the preview doesn't force the description field too far down

chpy04 · 2026-02-14T04:48:52Z

src/backend/src/prisma/schema.prisma

  dateCreated              DateTime                        @default(now())
  dateDeleted              DateTime?
  dateOfExpense            DateTime?
+  description              String?


copilot is correct here

chpy04 · 2026-02-14T04:49:49Z

src/backend/src/services/reimbursement-requests.services.ts

        identifier: numReimbursementRequests + 1,
-        organization: { connect: { organizationId: organization.organizationId } }
+        organization: { connect: { organizationId: organization.organizationId } },
+        description: description ?? ''


add default and then you don't need to check here

chpy04 · 2026-02-14T04:49:57Z

src/backend/src/services/reimbursement-requests.services.ts

      where: { reimbursementRequestId: oldReimbursementRequest.reimbursementRequestId },
      data: {
        dateOfExpense: dateOfExpense ?? null,
+        description: description ?? '',


chpy04 · 2026-02-14T04:50:05Z

src/backend/src/transformers/reimbursement-requests.transformer.ts

    saboId: reimbursementRequest.saboId ?? undefined,
    dateCreated: reimbursementRequest.dateCreated,
    dateOfExpense: reimbursementRequest.dateOfExpense ?? undefined,
+    description: reimbursementRequest.description ?? '',


chpy04 · 2026-02-14T04:50:11Z

...pages/FinancePage/EditReimbursementRequest/EditReimbursementRequestRenderedDefaultValues.tsx

          vendorId: reimbursementRequest.vendor.vendorId,
          indexCodeId: reimbursementRequest.indexCode.indexCodeId,
          dateOfExpense: reimbursementRequest.dateOfExpense ? new Date(reimbursementRequest.dateOfExpense) : undefined,
+          description: reimbursementRequest.description ?? '',


porpol added 18 commits January 11, 2026 23:33

#3776 added description field for reimbursement requests to prisma sc…

1e5de96

…hema

Merge branch 'develop' of https://github.com/Northeastern-Electric-Ra…

8cb0af5

…cing/FinishLine into 3776-maintenence---description-field-for-rr

#3776 added description

994c58c

#3776 updated reimbursement request services to include description f…

d0cb184

…ield

#3776 added description field to reimbursement request controllers

3878a29

#3776 modified reimbursement request routes to include description

3313663

#3776 added description param to edit/create rr docstrings

5e18136

#3776 made description a required field

35994ee

#3776 made description parameter optional for create and edit rr serv…

52dd0b0

…ices

#3776 added example description for rr in seed

dc13de7

#3776 added description field to rr view modal and rr info table

12acfbb

#3776 added description field to search bar filter

af7e756

#3776 added description input field to rr form

b0ae073

#3776 merged develop into branch

e19f2d7

#3776 added description tooltip to rr table

483acb2

#3776 made it so that empty description strings can be submitted

99d8636

#3776 trims descriptions in default value for rr form

edfdc46

#3776 made migration for description field

cc7f6f5

porpol linked an issue Feb 8, 2026 that may be closed by this pull request

[Maintenence] - Description Field for RR #3776

Open

porpol self-assigned this Feb 8, 2026

#3776 fixed prettier formatting and linting errors

9702586

cielbellerose requested review from Steph375 and cielbellerose February 10, 2026 01:49

cielbellerose requested changes Feb 10, 2026

View reviewed changes

porpol added 3 commits February 10, 2026 18:48

#3776 changed input description to description in rr form

be6c617

#3776 moved description to end of rr form

81388a0

#3776 deleted migration for nonnull rr description, made description …

895cfc5

…optional

Copilot AI review requested due to automatic review settings February 11, 2026 00:18

Copilot started reviewing on behalf of porpol February 11, 2026 00:19 View session

This comment was marked as spam.

Sign in to view

#3776 made it so that rr transformer returns empty string if descript…

b144c13

…ion is null

Northeastern-Electric-Racing deleted a comment from Copilot AI Feb 11, 2026

porpol added 2 commits February 10, 2026 19:30

#3776 fixed prettier formatting

8d039fd

#3776 changed description in rr shared types to optional

86c3ad9

cielbellerose approved these changes Feb 13, 2026

View reviewed changes

cielbellerose requested a review from chpy04 February 13, 2026 00:24

chpy04 requested changes Feb 14, 2026

View reviewed changes

Conversation

porpol commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Screenshots

Checklist

Uh oh!

cielbellerose left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StephSayegh commented Feb 10, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

cielbellerose left a comment

Choose a reason for hiding this comment

Uh oh!

chpy04 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

porpol commented Feb 8, 2026 •

edited

Loading