Skip to content

[MIG] dms_attachment_link: Migration to 18.0#478

Open
IJOL wants to merge 16 commits into
OCA:18.0from
BITVAX:18.0-mig-dms_attachment_link
Open

[MIG] dms_attachment_link: Migration to 18.0#478
IJOL wants to merge 16 commits into
OCA:18.0from
BITVAX:18.0-mig-dms_attachment_link

Conversation

@IJOL

@IJOL IJOL commented Jun 3, 2026

Copy link
Copy Markdown

Migration of dms_attachment_link to 18.0.

This continues @hhgabelgaard's work in #460, which is a clean, history-preserving migration but has stalled after maintainer review: @flotho requested changes on 2026-02-20 (a runtime error reported on runboat) and the branch has not been updated since (its head was last pushed on 2026-02-04). This PR builds on top of that branch — preserving its full history and authorship — and adds the fix for the reported issue.

On top of #460:

  • Inject the action service into the Chatter patch via setup() / useService("action"). In Odoo 18 the Chatter no longer exposes this.action, so _onAddDmsFile() raised TypeError: this.action is undefined when clicking "Add DMS file" — the runtime error seen in @flotho's review.
  • Add a scoped scss so the file selector kanban does not collapse to ~17px inside the wizard dialog.
  • Regenerate the README (badges/links still pointed to 17.0).

Credit for the migration goes to @hhgabelgaard and the original authors. Supersedes #460.

@flotho @hhgabelgaard

@OCA-git-bot OCA-git-bot added series:18.0 mod:dms_attachment_link Module dms_attachment_link labels Jun 3, 2026
victoralmau and others added 16 commits June 3, 2026 15:46
TT41512

[UPD] Update dms_attachment_link.pot

[UPD] README.rst
…selection.

TT41512

[UPD] Update dms_attachment_link.pot

dms_attachment_link 13.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: dms-13.0/dms-13.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-13-0/dms-13-0-dms_attachment_link/
TT41774

[UPD] Update dms_attachment_link.pot

[UPD] README.rst
Currently translated at 100.0% (6 of 6 strings)

Translation: dms-15.0/dms-15.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_attachment_link/es/

[UPD] README.rst
Translated using Weblate (Italian)

Currently translated at 100.0% (6 of 6 strings)

Translation: dms-15.0/dms-15.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_attachment_link/it/
[UPD] Update dms_attachment_link.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: dms-17.0/dms-17.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-17-0/dms-17-0-dms_attachment_link/
Currently translated at 100.0% (7 of 7 strings)

Translation: dms-17.0/dms-17.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-17-0/dms-17-0-dms_attachment_link/it/
…dialog

In Odoo 18 the Chatter component no longer exposes `this.action`, so clicking
"Add DMS file" raised `TypeError: this.action is undefined`. Inject the action
service in setup() via useService("action").

The file selector kanban also collapsed to ~17px inside the wizard dialog (its
container takes its height from flex, so the renderer default min-height:100%
does not resolve). Add scoped scss to give the renderer a viewport height inside
the dialog.

Also regenerate the README (badges/links still pointed to 17.0).
@IJOL IJOL force-pushed the 18.0-mig-dms_attachment_link branch from c6acdfd to b92b548 Compare June 3, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:dms_attachment_link Module dms_attachment_link series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants