unit-tests for utils::segmented_read() and utils::segmented_write() #348
Draft
unit-tests for utils::segmented_read() and utils::segmented_write() #348
Conversation
jgallagher59701
approved these changes
Apr 3, 2026
Member
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
Looks good; pending one change. The 'suggestion' may need to tweaked since this if the first time I used that.
Also, for the clang formatting, if you look in the README.pre-commit.md it explains how to set up the pre-commit system so your code is auto formatted to for commits.
| // Open the file in binary mode | ||
| std::ofstream outfile(filepath, std::ios::out | std::ios::binary); | ||
|
|
||
| if (!outfile) { |
Member
There was a problem hiding this comment.
Here I would throw an exception. The DBG(...); output is fine, so do that first. Then,
Suggested change
| if (!outfile) { | |
| if (!outfile) { | |
| // errno captures the specific OS error that occurred during the open attempt | |
| throw std::system_error(errno, std::generic_category(), "Failed to open " + filepath); | |
| } |
You may have to add a new header like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference ticket: HYRAX-1758
Tasks