Conversation
We may need 12G for the cache, but maybe 1G is OK if it's compressed
The BaseType::width_ll() method defines a parameter that is not used by scalar types. I changed the code to silence that warning.
…the DAP4 scanners.
The test was not correctly waiting for the D4StreamMarhaller child thread to complete, leading to intermittent failures.
Also, remvoed a bunch of ancient stuff from retired.
|
There was a problem hiding this comment.
i'm a little surprised that there are new data files being checked in with this PR---is this intentional? ditto some of the tweaks in "types". if intentional, great! they just seem unrelated to build speedup stuff...
There was a problem hiding this comment.
Yeah. So part of the reason I wanted to close this and move on is that I also fixed a bug in D4StreamMarshaller that I could only see once I was running PRs over and over. It's odd, because I edited the description of the PR, but that seems gone. Anyway, this PR closes that issue with D4StreamMarshallerTest (I fixed the test but did not change how the code works).
There was a problem hiding this comment.
Ah, okay! Yes, that makes sense.
There was a problem hiding this comment.
And, I should add, that this work has uncovered other issues too, but I don't want them to muddy up things more.
2 participants
No description provided.