Conversation
BSzymanowski
requested review from
PhilipFackler,
abirchfield,
lukelowry and
pelesh
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Nice work! Please update README files with documentation on outputs.
| monitor_->set(Variable::im1, [this] | ||
| { return std::sqrt(Ir1() * Ir1() + Ii1() * Ii1()); }); | ||
| monitor_->set(Variable::p1, [this] | ||
| { return Vr1() * Ir1() + Vi1() * Ii1(); }); | ||
| monitor_->set(Variable::q1, [this] | ||
| { return Vi1() * Ir1() - Vr1() * Ii1(); }); |
There was a problem hiding this comment.
Please add section "Model Outputs" to the branch model README file and describe all outputs there. Please explain how active and reactive power are computed and what is the sign convention.
| monitor_->set(Variable::ksat, [this] | ||
| { return SB_ * (((y_[2] - SA_) * Math::sigmoid(y_[2] - SA_)) * ((y_[2] - SA_) * Math::sigmoid(y_[2] - SA_))); }); |
There was a problem hiding this comment.
Please add section "Model Outputs" to the exciter model README file and describe all outputs there. Please explain how saturation is computed.
| monitor_->set(Variable::p, [this] | ||
| { return Vr() * Ir() + Vi() * Ii(); }); | ||
| monitor_->set(Variable::q, [this] | ||
| { return Vi() * Ir() - Vr() * Ii(); }); |
There was a problem hiding this comment.
Please add section "Model Outputs" to the generator model README file and describe all outputs there. Please explain how active and reactive power are computed and what is the sign convention.
| monitor_->set(Variable::p, [this] | ||
| { return Vr() * Ir() + Vi() * Ii(); }); | ||
| monitor_->set(Variable::q, [this] | ||
| { return Vi() * Ir() - Vr() * Ii(); }); |
There was a problem hiding this comment.
Please add section "Model Outputs" to the generator model README file and describe all outputs there. Please explain how active and reactive power are computed and what is the sign convention.
pelesh
added
documentation
PhilipFackler
left a comment
PhilipFackler
left a comment
There was a problem hiding this comment.
This looks great. I'll leave correctness to be verified by others, but good job getting this done.
BSzymanowski
force-pushed
the
BSzymanowski/initializeMonitors
branch
from
dec28a8 to
e3f6bd2
Compare
|
README files updated with descriptions of all outputs and relevant calculations. |
3 participants
Description
Added outputs for initializeMonitor(); returns the value of the monitored variable.
Proposed changes
Return statements added for each monitored variable. The final value for that variable is now returned.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Kindly provide comments so that I may change the code if necessary.