Make Windows (MinGW G++) compatible#445
Open
andrewxu319 wants to merge 11 commits into
Open
Conversation
…As of this comment, the code works on MinGW g++.
nkoukpaizan
reviewed
Jun 10, 2026
| ```powershell | ||
| mkdir build | ||
| cd build | ||
| cmake -DCMAKE_INSTALL_PREFIX=/path/to/install -DBUILD_SHARED_LIBS=OFF ../ |
Collaborator
There was a problem hiding this comment.
Are different instructions really needed? The only difference I see with the earlier instructions is DBUILD_SHARED_LIBS=Off. I would recommend implementing a workaround for that in CMake instead.
Collaborator
Author
There was a problem hiding this comment.
Maybe not. Removed it for now. However I did also need to specify the directory ../ instead of ../GridKit.
Collaborator
There was a problem hiding this comment.
../GridKit is suggested for out-of-source builds, with the build and GridKit directories being at the same level in the file structure.
This reverts commit a5d7e80.
…t into andrew/windows-compatibility
Collaborator
|
re 5ffbf8d: I recommend rebasing ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make compiler-specific changes such that GridKit runs and pass all tests on Windows. Specifically, it now works with MinGW G++, but not MSVC.
Please describe the issue that is addressed (bug, new feature,
documentation, enhancement, etc.). Please also include relevant motivation and
context. List any dependencies that are required for this change.
Closes #(issue)
Mentions @(user)
Proposed changes
Describe how your changes here address the issue and why the proposed changes
should be accepted.
.string()to.filename()to extract the underlying string if the OS is Windows__attribute__((always_inline)) inlinewith a compiler-specificFORCE_INLINEmacrotoUpper()to avoid compiler errorsChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining
why you chose the solution you did and what alternatives you considered, etc...