Skip to content

Nuke COO_Matrix class#447

Draft
nkoukpaizan wants to merge 39 commits into
developfrom
nicholson/nuke-COO_Matrix
Draft

Nuke COO_Matrix class#447
nkoukpaizan wants to merge 39 commits into
developfrom
nicholson/nuke-COO_Matrix

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Work in progress to remove COO_Matrix class. The class is now gone, but the PR still needs some cleanup.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

nkoukpaizan added 30 commits June 10, 2026 12:28
@nkoukpaizan
WIP: nuke COO_Matrix class. Remove what's not needed and cleanup.
5df4a2f
@nkoukpaizan
Separate implementation and calls for DfDy and DfDyp.
04cda17
@nkoukpaizan
Update Component class templates.
6caca2c
@nkoukpaizan
Get ScalarT and IdxT from ModelT::ScalarT and ModelT::IdxT in Enzyme …
31623ad 
…wrappers.
@nkoukpaizan
Return nnz from partial derivative Enzyme wrappers.
2cbd8e6
@nkoukpaizan
Move csr_jac_ member variable from SystemModel to Component.
108dd16
@nkoukpaizan
Remove sorted_ member variable.
bd9e951
@nkoukpaizan
Store bus Jacobian contributions within Branch, Genrou and Gensal (in…
3479621 
…stead of axpy to bus-owned block).
@nkoukpaizan
Make BusFault store currents as internal variables --> can now also s…
3acf58d 
…tore bus Jacobian contribution.
@nkoukpaizan
Nuke COO_Matrix::axpy.
106633c
@nkoukpaizan
Bug fix in BusFault: always evaluate the residuals, but only contribu…
1f42515 
…te current injection to bus if status_.
@nkoukpaizan
Nuke COO_Matrix::zeroValuedMatrix.
ef11cc8
@nkoukpaizan
nnz-->block_nnz in component Jacobians.
4401cc7
@nkoukpaizan
Minor edits.
d7abb5f
@nkoukpaizan
.size()-->nnz_ in COO_Matrix.
dd137a7
@nkoukpaizan
Compute nnz_dup in component models (outside COO_Matrix).
c780799
@nkoukpaizan
PhasorDynamics::SystemModel should not need PhasorDynamics:: to acces…
78e929c 
…s ::Component.
@nkoukpaizan
Proof of concept to construct CsrMatrix at component level.
7f78513
@nkoukpaizan
constructCsrFromCOO in Component base class.
6f68059
@nkoukpaizan
Construct CsrMatrix for all components and update tests. Currently sl…
08c4007 
…ow for simulations, because of re-construction.
@nkoukpaizan
Nuke MapFromCOO.
af468a2
@nkoukpaizan
Assemble system Jacobian from component Csr (instead of COO).
a09de14
@nkoukpaizan
Nuke getJacobian method that returns COO_Matrix.
abda163
@nkoukpaizan
Only construct component-level CsrMatrix once.
911e7b3
@nkoukpaizan
No need for csr_jac_ counter at component level.
d6b594a
@nkoukpaizan
Use alias for CooMatrixT in SystemModel.
9852286
@nkoukpaizan
Remve Jacobian debug print from System model.
8a77560
@nkoukpaizan
Inline CooMatrix and CsrMatrix size accessors.
71d0e5f
@nkoukpaizan
Temporary variable for n_rows.
ce79f73
@nkoukpaizan
A few more inline.
5e03014
@nkoukpaizan nkoukpaizan self-assigned this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nkoukpaizan nkoukpaizan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nkoukpaizan