Skip to content

Comments

github: change supported versions in different PR#4338

Open
KaloyanTanev wants to merge 1 commit intomainfrom
kalo/fix-relase-script-support-version
Open

github: change supported versions in different PR#4338
KaloyanTanev wants to merge 1 commit intomainfrom
kalo/fix-relase-script-support-version

Conversation

@KaloyanTanev
Copy link
Collaborator

@KaloyanTanev KaloyanTanev commented Feb 24, 2026

During the latest release there was an issue with the 2 PRs created from this pipeline. The first PR that bumped the v1.X-rc to v1.X in the main-v1.X branch did change the supported versions by adding the same, so it became:

var version = "v1.X" <--- changed in the same PR from "v1.X-rc"
...
func Supported() []SemVer {
	return []SemVer{
		{major: 1, minor: X}, <--- newly added line
		{major: 1, minor: X},
		{major: 1, minor: X-1},
...

Instead, we want this in the second PR that bumps v1.X-dev to v1.X+1-dev in the main branch, so that i becomes

var version = "v1.X+1-dev" <--- changed in the same PR from "v1.X-dev"
...
func Supported() []SemVer {
	return []SemVer{
		{major: 1, minor: X+1}, <--- newly added line
		{major: 1, minor: X},
		{major: 1, minor: X-1},
...

Check those 2 PRs for more context:
#4335
#4336

category: bug
ticket: none

@KaloyanTanev KaloyanTanev requested a review from pinebit February 24, 2026 16:55
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.37%. Comparing base (359d85c) to head (e35c609).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4338      +/-   ##
==========================================
- Coverage   56.39%   56.37%   -0.03%     
==========================================
  Files         237      237              
  Lines       31696    31697       +1     
==========================================
- Hits        17875    17869       -6     
- Misses      11533    11540       +7     
  Partials     2288     2288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev changed the title github: Change supported versions in different PR github: change supported versions in different PR Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant