Align labs rpc and local rpc on the path at least#217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem to be solved
I didn't want to have to modify code to point from the local rpc (running in the stack), to pointing at obol rpc. the problem is the paths to our L1 json rpc are different:
Labs: https://erpc.gcp.obol.tech////"
On host: http://obol.stack/rpc/mainnet/
In stack: http://erpc.erpc.svc.cluster.local:4000/
Proposed solution
This fixes some of the issues (erpc config was rpc not network. but its hard to get three different domains identical. We should decide what's worth changing towards. maybe something like:
Labs: https://erpc.gcp.obol.tech/rpc/mainnet
On host: http://obol.stack/rpc/mainnet
In stack: http://rpc.erpc.svc.cluster.local/rpc/mainnet
If so i have changes in obol-infrastructure, and obol-stack-front-end to make before this should be merged.