Conversation
ATGardner
force-pushed
the
noamgal/md-1571-add-sortable-field-to-created-interruption-and-service
branch
from
f27c046 to
e111f9e
Compare
ATGardner
force-pushed
the
noamgal/md-1571-add-sortable-field-to-created-interruption-and-service
branch
2 times, most recently
from
9563420 to
9e32aa9
Compare
flin-8
reviewed
Mar 27, 2026
|
|
||
| public record UpdatedSourceDetail( | ||
| string CommitSha, | ||
| DateTimeOffset CommitTimestamp, |
Contributor
There was a problem hiding this comment.
I think it makes sense for the timestamp to be null if we don't have one, convert it to some value on the Server side if needed
flin-8
reviewed
Mar 27, 2026
| namespace Calamari.ArgoCD.Conventions.ManifestTemplating; | ||
|
|
||
| public record ManifestUpdateResult(bool Updated, string CommitSha, List<FilePathContent> ReplacedFiles); No newline at end of file | ||
| public record ManifestUpdateResult(bool Updated, string CommitSha, DateTimeOffset CommitTimestamp, List<FilePathContent> ReplacedFiles); No newline at end of file |
flin-8
approved these changes
Mar 27, 2026
Contributor
flin-8
left a comment
flin-8
left a comment
There was a problem hiding this comment.
Looks good, just the comment re: nullable timestamp
dmaizel
approved these changes
Mar 29, 2026
ATGardner
force-pushed
the
noamgal/md-1571-add-sortable-field-to-created-interruption-and-service
branch
3 times, most recently
from
f39b6e5 to
b18824d
Compare
Enhance the ArgoCD reporting functionality by including a timestamp for each updated source detail. This change ensures that the commit timestamp is captured and serialized in the output, providing better traceability and context for deployments. Updated relevant classes and methods to accommodate the new timestamp parameter, ensuring consistency across the reporting and output variables.
Refactor the handling of commit timestamps in the ArgoCD reporting tests and related classes. Change the `CommitTimestamp` property to be nullable and update relevant usages to accommodate this change. This improves the flexibility of the reporting system when no commit timestamp is available.
ATGardner
force-pushed
the
noamgal/md-1571-add-sortable-field-to-created-interruption-and-service
branch
from
b18824d to
c943a03
Compare
ATGardner
deleted the
noamgal/md-1571-add-sortable-field-to-created-interruption-and-service
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the ArgoCD reporting functionality by including a timestamp for each updated source detail. This change ensures that the commit timestamp is captured and serialized in the output, providing better traceability and context for deployments.
Updated relevant classes and methods to accommodate the new timestamp parameter, ensuring consistency across the reporting and output variables.
relevant server changes are being made in https://github.com/OctopusDeploy/OctopusDeploy/pull/41188 pr