Open
Conversation
0a3e4da to
2044772
Compare
2044772 to
dbbb1a9
Compare
dc561ba to
51181a3
Compare
…atches-only-newtag-could-we
Contributor
|
There's a few smells in the KustomizeUpdater which should be easy to fix. But a few general thoughts:
|
0991d49 to
c42805b
Compare
rain-on
approved these changes
Mar 25, 2026
Contributor
rain-on
left a comment
There was a problem hiding this comment.
still need to review the tests - but generally like the layout 👍
If you find any of the comments disingenuous, leave them out, we can work through them in person
source/Calamari/ArgoCD/Conventions/UpdateImageTag/KustomizeContainerImageReplacer.cs
Outdated
Show resolved
Hide resolved
| } | ||
| else | ||
| { | ||
| var patchType = DeterminePatchTypeFromFile(input); |
Contributor
There was a problem hiding this comment.
this is nice :)
You COULD break this block out to a separate function too but that's just an opinion.
source/Calamari/ArgoCD/Conventions/UpdateImageTag/KustomizeContainerImageReplacer.cs
Outdated
Show resolved
Hide resolved
source/Calamari/ArgoCD/Conventions/UpdateImageTag/KustomizeContainerImageReplacer.cs
Outdated
Show resolved
Hide resolved
| { | ||
|
|
||
| var hasOpField = System.Text.RegularExpressions.Regex.IsMatch(content, | ||
| @"[""']?op[""']?\s*:\s*[""']?(add|remove|replace|move|copy|test)[""']?", |
Contributor
There was a problem hiding this comment.
I LOVE regular expressions :) But no one else does - is there any easy way to do this without the regex?
rain-on
reviewed
Mar 25, 2026
rain-on
reviewed
Mar 25, 2026
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
db12f10 to
81b7372
Compare
…-files-do-not-support-patches-only-newtag-could-we
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Kustomize patching in ArgoCD deployments. The PR implements patch discovery and image replacement capabilities for different patch types:
Testing:
Tested local Calamari with an local Octopus Server instance:
The changed commit a2defd6f2a showed that it consistently updated the image tags properly across all scenarios.