Improving logging around receiving data streams.#1202
Merged
LukeButters merged 3 commits intomainfrom Mar 30, 2026
Merged
Conversation
LukeButters
commented
Mar 30, 2026
|
|
||
| namespace Octopus.Tentacle.Core.Configuration | ||
| { | ||
| public static class TentacleHalibutTimeoutAndLimitsFactory |
Contributor
Author
There was a problem hiding this comment.
This has been refactored to the tentacle core, so that we can use in process tentacles that use the same HalibutTimeoutAndLimits.
LukeButters
commented
Mar 30, 2026
|
|
||
| if (!bool.TryParse(Environment.GetEnvironmentVariable(EnvironmentVariables.TentacleUseRecommendedTimeoutsAndLimits), out var useRecommendedTimeoutsAndLimits)) | ||
| { | ||
| useRecommendedTimeoutsAndLimits = true; |
Contributor
Author
There was a problem hiding this comment.
Default was true, now it is always true. It can no longer be set by the env var. We never needed to set it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes: #1203
ref CLOUDPT-11160
ref EFT-3141
Improves the logging around errors when receiving data streams. We will now get errors like:
When not enough data has been sent. The change is from Halibut, simply updating the version improves the logging.
Note that we do not throw on data stream length miss-match, since we want to try this out in Octopus before enabling on Tentacle. It is configurable by an environment variable.
This updates the version of Halibut to include:
Additionally this PR updates the nuget config to allow fetching Halibut from feedz, which is where the pre-release versions are stored.
We also removed the ability to disable recommended TCP settings, since that has been enabled for sometime now.
Results
How to review this PR
Quality ✔️
Pre-requisites